Zijun Zhou Eary
  • Joined on 2019-09-02
Zijun Zhou commented on pull request blender/blender#106355 2023-04-02 01:57:43 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Ok I added the sRGB display's native back as Legacy Standard. Design-wise I am not comfortable with this decision. I hope the community in the long run can get rid of the out-dated practice of…

Zijun Zhou commented on pull request blender/blender#106355 2023-04-02 01:18:22 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Again, the goal of view transform is not technical sRGB conversion, it's instead, image formation. Therefore as long as visually extremely similar, it's acceptable.

Technically it's completely…

Zijun Zhou commented on pull request blender/blender#106355 2023-04-01 10:02:57 +02:00
Replace Default OCIO config with AgX (Filmic v2)

OK I can change the working space back to I-D65 for now. But note for Spectral Cycles, I-E working space is an absolute must, we are just delaying the decision to when Spectral Cycles's turn comes.

Zijun Zhou commented on pull request blender/blender#106355 2023-04-01 09:14:21 +02:00
Replace Default OCIO config with AgX (Filmic v2)

To take full advantage of spectral rendering a wider gamut is needed anyway. I don't think we should switch this one to be I-E based if it causes such issues.

I am sure none of these use…

Zijun Zhou commented on pull request blender/blender#106355 2023-04-01 07:29:44 +02:00
Replace Default OCIO config with AgX (Filmic v2)

I added back the Filmic Look LUTs, but not in the config yet. Will wait until the code specifies to only show looks with Filmic - in front when choosing Filmic.

Zijun Zhou commented on pull request blender/blender#106355 2023-04-01 06:42:50 +02:00
Replace Default OCIO config with AgX (Filmic v2)

The Filmic looks are needed for backwards compatibility. We also can't just change their name to add - Filmic since that breaks compatibility too. So some solution in the code is needed.

I…

Zijun Zhou commented on pull request blender/blender#106355 2023-04-01 04:34:52 +02:00
Replace Default OCIO config with AgX (Filmic v2)

For example inputting an RGB of 1.0, 0.0, 0.0 results in #FF150B, and inputting #FF0000 sets the RGB to 0.887905, 0.0, 0.0 as well as immediately changes the hex value. This doesn't occur in…

Zijun Zhou commented on pull request blender/blender#106355 2023-03-31 18:03:04 +02:00
Replace Default OCIO config with AgX (Filmic v2)

The current config does not have Filmic looks in there. But from another angle, you can still use those Looks with Filmic, just keep in mind those looks were mpt designed with Filmic in mind…

Zijun Zhou commented on pull request blender/blender#106355 2023-03-31 12:57:05 +02:00
Replace Default OCIO config with AgX (Filmic v2)

I believe I have addressed all the comments.

Zijun Zhou commented on pull request blender/blender#106355 2023-03-31 12:24:32 +02:00
Replace Default OCIO config with AgX (Filmic v2)

I still disagree but I can add it back. Note Spectral Cycles requires XYZ chromaticity with I-E white point, the current aces_interchange role doesn't deal with that. Keep in mind we might need…

Zijun Zhou commented on pull request blender/blender#106355 2023-03-31 12:15:59 +02:00
Replace Default OCIO config with AgX (Filmic v2)

aces_interchange currently overwrites the XYZ role, causing problem for Spectral Cycles to access the XYZ I-E chromaticity. We can add it back after the chromaticity in the render engines is…

Zijun Zhou commented on pull request blender/blender#106355 2023-03-31 11:42:37 +02:00
Replace Default OCIO config with AgX (Filmic v2)

I have removed the power value number from names like sRGB, Display P3, etc. But for Generic Data, I am unwilling to change it, reasoning has been stated above.

Zijun Zhou commented on pull request blender/blender#106355 2023-03-31 11:15:06 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Filmic should still be included in the default Blender config for backwards compatibility, even if only supported for the sRGB display.

Filmic sRGB the space is still there, but my concern…

Zijun Zhou created pull request blender/blender#106355 2023-03-31 04:53:00 +02:00
Replace Default OCIO config with AgX (Filmic v2)
Zijun Zhou commented on issue blender/blender#106201 2023-03-29 19:45:05 +02:00
Cycles Blackbody does not correctly pick up the scene_linear color space

Comparing formed images by different view transform doesn't actually show whether it works corectly or not. You need to export EXR and plot the chromaticity to see it.

As I tested, the…

Zijun Zhou commented on issue blender/blender#105714 2023-03-15 04:35:20 +01:00
Supporting HDR workflows in Blender

Supporting HDR workflows in Blender One of the challenges is to preserve the Filmic View, which is currently designed for the sRGB screens. Arguably, it should be a look as it is often used for…

Zijun Zhou commented on issue blender/blender#103470 2023-02-21 22:27:19 +01:00
Add View Transform space to inactive_colorspaces Causes extra transform when saving 16 bit PNG

This should be quite easy to reproduce, why is it not even confirmed?