Emmett-Lalish
  • Joined on 2024-02-27
Emmett-Lalish commented on issue blender/blender#123940 2024-07-04 01:01:17 +02:00
Khronos PBR Neutral has unexpectedly bright shadows

Thank you, that's an interesting test case. I think I even know what's causing this in our function, which is specific to a gradient that takes one channel to zero while the others are constant.…

Emmett-Lalish commented on issue blender/blender#123514 2024-06-21 22:58:30 +02:00
Khronos PBR artifacts with certain bright colours

I can't speak to the volumetrics, but as far as tone mapping this is expected behavior. As I've said, PBR Neutral is not better than AgX, it simply has different tradeoffs. AgX is a filmic tone…

Emmett-Lalish commented on pull request blender/blender#118936 2024-06-09 19:42:56 +02:00
Add Khronos PBR Neutral tone mapper

ACES defines a lot of things, both color spaces and tone mapping functions like these. A LUT (look-up table) is just a particular method of defining a mapping function. It's confusing because even…

Emmett-Lalish commented on issue blender/blender#120182 2024-05-08 18:11:22 +02:00
More Boolean Solvers
  1. Two cubes side-by-side sharing a face (just one!) where they touch. This is non-manifold but to many "it seems clear" that the face that is inside the two cubes is inside, so a self-union…
Emmett-Lalish commented on issue blender/blender#120182 2024-05-07 17:55:41 +02:00
More Boolean Solvers

Ember might be faster than Manifold huge models, because it pays more attention to short-circuiting around large parts of models that are unaffected by intersection. But this is just a…

Emmett-Lalish commented on pull request blender/blender#118936 2024-03-16 00:03:08 +01:00
Add Khronos PBR Neutral tone mapper

One last small update - we just got some feedback that it's very useful to have analytical inverses for tone mapping functions. Ours was difficult to invert, but with a tiny change, it becomes…

Emmett-Lalish pushed to pbrNeutral at Emmett-Lalish/blender 2024-03-15 23:59:41 +01:00
1a999fc046 update for invertibility
Emmett-Lalish commented on pull request blender/blender#118936 2024-03-14 00:31:55 +01:00
Add Khronos PBR Neutral tone mapper

@brecht Thanks for the pointer - done!

Emmett-Lalish pushed to pbrNeutral at Emmett-Lalish/blender 2024-03-14 00:30:37 +01:00
1539d2d18d addressing feedback
Emmett-Lalish commented on pull request blender/blender#118936 2024-03-11 23:15:37 +01:00
Add Khronos PBR Neutral tone mapper

Okay, I've improved the OCIO approximation by extending to lower values that cover the low end of sRGB better. Of course it could be further improved by increasing the resolution of the LUT, but I…

Emmett-Lalish pushed to pbrNeutral at Emmett-Lalish/blender 2024-03-11 23:09:36 +01:00
dce785911c improved OCIO approximation
Emmett-Lalish commented on pull request blender/blender#118936 2024-03-11 20:15:26 +01:00
Add Khronos PBR Neutral tone mapper

@jorn Thank you for the detailed analysis! You're absolutely correct about the tradeoffs vs Standard, and thanks for the excellent test image showing the errors in my OCIO approximation - I'll use…

Emmett-Lalish commented on pull request blender/blender#118936 2024-03-07 20:33:52 +01:00
Add Khronos PBR Neutral tone mapper

From what I can tell, this maps scene linear 0 0 0 to 0.0196 0.0196 0.0196. Which makes pure black unattainable, because you can't go lower for the scene linear color? Is that really…

Emmett-Lalish commented on pull request blender/blender#118936 2024-03-07 17:47:11 +01:00
Add Khronos PBR Neutral tone mapper

@brecht Thank you, and the answer to your naming question is actually related to @JoelR_VC's question about the blacks. Khronos did hold a vote and officially name this the Khronos PBR Neutral…

Emmett-Lalish commented on pull request blender/blender#118936 2024-03-05 20:16:36 +01:00
Add Khronos PBR Neutral tone mapper

Perfect, thanks @Sergey. That will definitely be follow-on work; not sure how long it'll take and I think we should be sure everyone's happy with this first PR before getting started.

Emmett-Lalish commented on pull request blender/blender#118936 2024-03-04 20:45:01 +01:00
Add Khronos PBR Neutral tone mapper

By the way, if there's anyone here who would like to nerd out about HDR displays and wide color gamuts, please let me know. I have an M1 Macbook Pro and I was playing with Blender's HDR support,…

Emmett-Lalish commented on pull request blender/blender#118936 2024-03-01 01:05:58 +01:00
Add Khronos PBR Neutral tone mapper

By the way, thank you Blender devs! I had nearly given up on generating an OpenColorIO config for this tone mapper, as their documentation is so utterly useless, when it occurred to me that…

Emmett-Lalish commented on pull request blender/blender#118936 2024-02-29 23:16:59 +01:00
Add Khronos PBR Neutral tone mapper
Emmett-Lalish commented on issue blender/blender#118824 2024-02-29 23:16:20 +01:00
Proposal: add a view transform for Khronos PBR Neutral Tone Mapper

Done! Please let me know if there's anywhere I should put or reference my LUT generation script. Likewise please point me to any documentation you'd like to see updated (does that happen in the…

Emmett-Lalish created pull request blender/blender#118936 2024-02-29 23:10:29 +01:00
Add Khronos PBR Neutral tone mapper