However, I still think it might be better to fix the line for cleaner code. Explicit type conversion prevents data loss and increases clarity.
Ok the error from your CMakeLists.txt appeared to stop me from building it. I upgraded my g++ to 11 and rebuilt it. Now it can compile fine without giving me any errors.
Btw, your message…
@Giang-Chaebol building shouldn't even have started since CMake checks GCC is at least 11.0.0, did you modify
CMakeLists.txtin order to get Blender building?What does
gcc --version…
@Giang-Chaebol building shouldn't even have started since CMake checks GCC is at least 11.0.0, did you modify
CMakeLists.txtin order to get Blender building?What does
gcc --version…
In the build output there is the message "unrecognized command line option" this is a hint that there is something wrong with the build as CMake is meant to detect this flag and only pass it in…
@Giang-Chaebol it's strange that your running into these errors as I don't get them with recent Linux/macOS build environments, what compiler version are you using?
(multiverse)…It still gives me the error, see the video.
Sorry, but I'm not seeing the error in that video. Although you have blf_glyph.cc loaded, the capture is showing terminal messages to do with…
Hello, and thanks for looking at this. My compiler is not giving me this same warning, so I am a bit blind here.
This warning is about an assignment to uchar from a function that returns…
What is your compiler version? Does it match the requirements here? https://developer.blender.org/docs/handbook/building_blender/#compiler-versions
$ gcc --version gcc (Ubuntu 11.4.0-2ubuntu1…
- Could you combine the other PRs with similar changes into this one? Splitting the change in three doesn't really help.
- This is missing clang format. Please read https://developer.blender.o…
Please be consistent, should I target these PRs at main? If so, do I need to split the PR into changes of each file?
Thanks for the fix. Please use functional style type casts for integer types, as mentioned in the style guide.
Done.
Nope, still the same, with or without const in <>
blender/source/blender/blenkernel/intern/bvhutils.cc:962:83: error: invalid static_cast from type ‘BMLoop* (*)[3]’ to type ‘const…No, it will raise the same error invalid const_cast from type ‘BMLoop* (*)[3]’ to type ‘const BMLoop* (*)[3]’, because em->looptris is not a const
I seperated it into 7 Pull Requests: blender/blender#120877 blender/blender#120879 https://projects.blender.org/blender/blen…