Hombre57
  • Metz, FRANCE
  • Joined on 2024-05-30
Hombre57 commented on issue extensions/io_scene_x3d#12 2024-09-08 00:19:57 +02:00
Scale geometry when importing shapes

I've created the import-scale branch that implement scaling, with a combobox for file unit selection or using a scale value. I chose to modify the base data instead of using the transformation…

Hombre57 created pull request extensions/io_scene_x3d#16 2024-09-08 00:14:48 +02:00
WIP: Fix issue #12: Scale geometry when importing shapes
Hombre57 pushed to import-scale at Hombre57/io_scene_x3d 2024-09-07 23:36:08 +02:00
04d59ff291 Fix issue #12: Scale geometry when importing shapes
844456f64a fix issue with copyright notice in blender_manifest: only numbers allowd
854dd41c65 update license, bump version to 2.3.6
ed833aa122 fix extensions/io_scene_x3d#15 by utilizing try catch for color_per_vert
3765ea5268 update copyright note: add contribution years
Compare 8 commits »
Hombre57 created branch import-scale in Hombre57/io_scene_x3d 2024-09-07 23:36:08 +02:00
Hombre57 commented on issue extensions/io_scene_x3d#11 2024-08-09 23:31:00 +02:00
[TODO] Create some sample wrl and x3d testing files

@Bujus_Krachus

Thanks for the commit rights Cedric.

About "the most basic and widely used features", which one are they ? I only use one : IndexedFaceShape. Anyway, I'll try to produce…

Hombre57 pushed to main at Hombre57/io_scene_x3d 2024-08-09 21:13:42 +02:00
f45f00ec95 disable h3d extensions export option
Hombre57 opened issue extensions/io_scene_x3d#12 2024-08-09 16:37:41 +02:00
Scale geometry when importing shapes
Hombre57 commented on issue extensions/io_scene_x3d#11 2024-08-09 15:32:11 +02:00
[TODO] Create some sample wrl and x3d testing files

@Bujus_Krachus I can provide some VRML files, not sure for X3D ones. I can have access to NX, TopSolid and Solidworks. It'll only cover a small subset of VRML/X3D possibilities. I can also compile…

Hombre57 deleted branch per-vertex_normals_and_colors from Hombre57/io_scene_x3d 2024-08-09 12:35:21 +02:00
Hombre57 pushed to main at Hombre57/io_scene_x3d 2024-08-07 21:24:20 +02:00
975d4ebb2e Fix per vertex normals and colors import (#6)
Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-08-07 11:41:16 +02:00
Fix per vertex normals and colors import

Done ! Thanks for the patch @Bujus_Krachus 👍

As a future improvement (as i've read you're interested in doing so), maybe let the users choose on the import which color space to display…

Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-08-07 11:33:31 +02:00
c957f6bc57 Handle color space for vertex colors using the color_attributes API
Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-08-07 00:58:44 +02:00
Fix per vertex normals and colors import

@Bujus_Krachus It looks like that the 2 colors are defined with the sames values but with different result.

Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-08-06 22:15:37 +02:00
cf37b9d1b7 Merge branch 'main' into per-vertex_normals_and_colors
142f42d25e update README.md
b56636170f X3D/VRML import: Fix blender/blender-addons#98442, check if USE-based cache is set in IndexedFaceSet (#7)
b3960fe844 fix quote detection of multi-line VRMLscripts (#5)
a33ad05f5d fix wrl files with pixel image textures not importing correctly (#4)
Compare 7 commits »
Hombre57 pushed to main at Hombre57/io_scene_x3d 2024-08-06 21:29:38 +02:00
142f42d25e update README.md
b56636170f X3D/VRML import: Fix blender/blender-addons#98442, check if USE-based cache is set in IndexedFaceSet (#7)
b3960fe844 fix quote detection of multi-line VRMLscripts (#5)
a33ad05f5d fix wrl files with pixel image textures not importing correctly (#4)
0d539de1fd add checks for NoneType to ignore empty shape nodes (#3)
Compare 6 commits »
Hombre57 commented on pull request extensions/io_scene_x3d#7 2024-08-05 20:44:32 +02:00
X3D/VRML import: Fix blender/blender-addons#98442, check if USE-based cache is set in IndexedFaceSet

Hi @nickberckley (ping @ideasman42),

I'm a CAD user and have worked with VRML already (before X3D appeared) and can help as well if time permit, though @Bujus_Krachus is more knowledgeable in…

Hombre57 commented on pull request extensions/io_scene_x3d#2 2024-08-05 17:49:56 +02:00
fix list index out of range for color_per_vertex

@Bujus_Krachus

Btw the missing colorAttribute node and smooth shading will probably be fixed by a merge with your PR

Yes, I manually merged this branch in PR #6 and it loaded with normals…

Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-08-05 13:59:05 +02:00
e8940cbc8c Use plain english for Color attribute's name
Hombre57 commented on pull request extensions/io_scene_x3d#2 2024-08-04 20:32:07 +02:00
fix list index out of range for color_per_vertex

@Bujus_Krachus

Didn't you mean index instead of color_index [here](e8e3c6454c/source/import_

Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-08-04 19:13:28 +02:00
Fix per vertex normals and colors import

Damn ! I'm not used to produce such crappy commits 😶‍. Back and forth testing and yep, that line was gone. It still works w/o that line here, so that's why I didn't noticed it was gone.