X3D/VRML import: Fix blender/blender-addons#98442, check if USE-based cache is set in IndexedFaceSet #7
No reviewers
Labels
No Label
bug
confirmed
duplicate
enhancement
help wanted
High
known issue
Normal
not a task
question
task
wontfix
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: extensions/io_scene_x3d#7
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "Bujus_Krachus/io_scene_x3d:add-check-for-USE-based-cache"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Ported blender/blender-addons#104596 to new repository:
Some X3D/VRML files would fail to import due to the code in importMesh_IndexedFaceSet not checking whether the USE-based cache was actually initialized before using it. This PR adds that check.
Fixes blender/blender-addons#98442
original comitter: @uh-wot
Hey Cedric, I see you're very active on this repo. I can try to help you out, but honestly I'm not familiar with those formats at all and I don't know how much help I can be. I can just review style and commit, but would you be interested in taking over as extension maintainer? You'll gain commit rights to repo (or you can use your own) and be responsible for it in the future
Hey @nickberckley,
very active is relative. I just stumbled upon a recent report and tried fixing it, which resulted in a few more reports getting (hopfully) fixed. I'm not too experienced with the format either, so currently limiting myself to bug fixing or improvement of life fixes only. But sure, you can add me as a maintainer if that takes workload away from you and the official blender devs. At least until somebody else is interested in that role and enough knowing of the format.
Btw would keep the repo here, as blenders gitea version is actually quite good ^^
Thanks for asking :)
Hi @nickberckley, any updates on the open question regarding maintainer and/or reviewing/merging pending open PRs?
Hi @nickberckley (ping @ideasman42),
I'm a CAD user and have worked with VRML already (before X3D appeared) and can help as well if time permit, though @Bujus_Krachus is more knowledgeable in Python than me. I plan to add other enhancement to this add-on, but I'm waiting on some PR to be merged first to build on them (it would greatly simplify our task on PR maintenance if they could be committed once ready). So I'd second your proposal to grant @Bujus_Krachus commit rights for this extension. He's actually very prone on reviewing my patch (see PR #6) and helped me a lot on making it final.
Hope you can find time to either review our PR or grant him commit rights.
hi @Bujus_Krachus thanks for your contributions I granted you write access to this repository. To give you access to update the extension itself I need you to first login on extensions.blender.org. This will create an account that I can connect to the extension. After you are done with this, could you please email me (dalai@blender.org) so I can send you some extra instructions?
Meanwhile I will discuss with Campbell (original developer) the overall ownership of the project. He is fine with it we can transfer it to you completely. Otherwise we have you as maintainer for now.