Hombre57
  • Metz, FRANCE
  • Joined on 2024-05-30
Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-08-04 19:13:04 +02:00
d17730d608 Add forgotten mathutils import
Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-08-04 17:19:50 +02:00
Fix per vertex normals and colors import

@Bujus_Krachus The fix for lack of decimals in vector components is pretty simple. I've committed a patch to add the normalization step. The Machine.wrl file is correctly imported now, with no…

Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-08-04 17:14:26 +02:00
0b42c37959 Add vector normalization step to handle vectors with too few decimals
Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-08-04 12:44:24 +02:00
Fix per vertex normals and colors import

I think it's useless, but I don't know the API enough to decide, so I'll take your conservative advice and leave it in.

The color attribute is fixed, my fault of a half imported patch,…

Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-08-04 12:42:55 +02:00
6007d1651d Merge branch 'main' into per-vertex_normals_and_colors
792b2c5ce5 Fix error importing files with one color for all faces
Compare 2 commits »
Hombre57 pushed to main at Hombre57/io_scene_x3d 2024-08-04 11:59:59 +02:00
792b2c5ce5 Fix error importing files with one color for all faces
Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-08-04 11:38:27 +02:00
30c46be9ff Fix the color attribute's name to avoid script crash
Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-08-04 00:25:32 +02:00
Fix per vertex normals and colors import

PS : As for reintroducing line 1960, I've tested that and didn't see any difference. Are you sure it's required since normals_split_custom_set does all the job ? Also, shouldn't we use…

Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-08-03 23:41:21 +02:00
Fix per vertex normals and colors import

@Bujus_Krachus I finally had time to work on this. I've added the support of per vertex normals w/o normal index and changed the conditions for setting the polygon smooth.

Depending the data in…

Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-08-03 23:04:07 +02:00
790902323c Add support for per vertex normals w/o normalIndex
Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-07-23 01:54:08 +02:00
Fix per vertex normals and colors import

One more question : are normals from this file correctly imported ? Seems weird. It comes from the Siemens NX CAD software, using the same Parasolid modeler than TopSolid, so it should be as clean…

Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-07-23 01:49:00 +02:00
Fix per vertex normals and colors import

I spent way too much time on that connexion problem, I finally made the change online, as you suggested @Bujus_Krachus.

The last commit remove the useless comments and only keep one validate()

Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-07-23 00:49:08 +02:00
37e6f48a33 Better node placement + code cleanup and simplification
Hombre57 commented on issue blender/blender-addons#51334 2024-07-22 21:45:38 +02:00
IndexError: list index out of range while importing wrl file

Hi @Sergey, I finally find out how to make a proper link to a subproject PR : extensions/io_scene_x3d#1 Sorry for the inconvenience.

Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-07-22 00:36:35 +02:00
Fix per vertex normals and colors import

I couldn't install the extension on 4.2.0 for now, the installation fail (I already opened an issue). So yes, it…

Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-07-21 17:03:05 +02:00
Fix per vertex normals and colors import

Ok, then for the record, the normals.wrl file is issued by TopSolid V6 with normals per vertex. colors.wrl is a truncated file from another ticket I can't get my hand on anymore.

  • A : File…
Hombre57 commented on issue blender/blender-addons#51334 2024-07-21 16:20:06 +02:00
IndexError: list index out of range while importing wrl file

For the record, PR #1 will fix the issue and load this invalid file.

Hombre57 commented on pull request extensions/io_scene_x3d#6 2024-07-21 13:55:16 +02:00
Fix per vertex normals and colors import

There was no opened ticket for that, should I've had open one first ?

Hombre57 commented on pull request extensions/io_scene_x3d#2 2024-07-21 12:32:52 +02:00
fix list index out of range for color_per_vertex

@Bujus_Krachus That's clean ! 😃 Thanks for the update.

Who's reviewing and accepting the PR ? (yes, I'm new here)

Hombre57 commented on pull request extensions/io_scene_x3d#4 2024-07-21 12:17:35 +02:00
fix wrl files with pixel image textures not importing correctly

Works fine with my VRML files, thanks 👍