@OmarEmaraDev So there you have it. Thanks again @Raiko for your explanation!
@JacquesLucke I updated the patch description.
Here's the .blend file you requested: Modulo_Test.blend
It shows the behavior of all…
Also code wise I noticed, that there is actually no to replace any functions. Simple replacing 2.0 with lacunarity already does the trick. And for the normalization an if statement around the…
What is a practical example for turning off normalization? Pretty mich all cases where the height of the Fractal Perlin noise actually matters, like with procedural terrain generation.
…
Code wise the fractal_voronoi_x_fx function from
template<typename T> |
I've only added the inputs for now but knowing how long the review process takes, I created the PR so design questions can already be discussed.
96980b24b7
-- Rename variable "normalize" to "use_normalize" for OSL to keep consistent with Voronoi.
Well of course it's possible to create your own operations out of more elementary operations but with that logic most operations should be removed.
Why need Subtract if you could Multiply by…
Math is already hard enough for many artists, so I don't see how obfuscating common math operations behind other less common operations is a good idea.
@mod_moder I don't see this as a duplication of functionality.
In fact before CharlieJolly pointed it out I didn't even know that you could use Wrap to emulate Floored Modulo and I think that…
I think the description of the operators could be improved and be made more user friendly.
Hmm, not sure what I could add to the description I think `The remainder of…
@mod_moder Quoting LazyDodo:
Mathematically : yes User experience wise: no
Unlike Floored Modulo the Wrap operation is a rather uncommon operation. Floored Modulo (a, b) is much more…
@LazyDodo The addition of Floored Modulo is exactly something that makes user experience better so I think were agreeing on that case here.