That would create a naming collision with noise::VoronoiParams params; in line 376. And out of the option of renaming noise::VoronoiParams or mf::Params I think that renaming mf::Params is…
Why output instead of octave? It only computes one octave not the entire output.
@fclem I didn't experience any problems with it and I also already know a solution to this. The thing is if we optimize out the if statements we'd get a GLSL implementation which is different…
If it actually turns out that the branches fail to get optimized, I'd say it's bets to just a separate different implementation for GLSL then. Instead of having the Fractalization process have…
Fair point. Let's see what Brecht's and Jacques's opinion are on that matter. Ah and I also didn't experience a performance regression in Cycles on my machine.
Apart from that is there…
@OmarEmaraDev If it's just about performance I think your concerns are unfounded. I did some performance tests and as expected, the performance difference for a single layer of Voronoi noise…
I am not the best person to give advice on how to do stuff in C++, but can't we just add the functions as template parameters and instantiate that function in an appropriately named function, or…
Now getting to the specificly mentioned points:
Why not write the macros as as function-style? For instance: I think this is cleaner and we can just eliminate params.feature…
A huge problem I faced when writing the code for Fractal Voronoi noise was that there were a lot inconsistencies between the different implementation. This starts at small things like the same…
Well, looks like Metal is still complaining https://builder.blender.org/admin/#/builders/135/builds/1182 error: no matching function for call to 'reduce_add'
Should I just change the…
@brecht "For the Metal errors you need to add the ccl_private qualifier for any pointer or reference argument. Also use mix instead of lerp."
Fixed that.
`"The HIP errors seem to be some…
@brecht It is done. Or rather it works on my machine but according to https://builder.blender.org/admin/#/builders/136/builds/1158 there seem to be errors on other machines.
For https://builder…