Hoshinova
1 Followers · 0 Following
  • Joined on 2023-04-11
Repositories
1
 Projects Public Activity Starred Repositories
1
Hoshinova commented on pull request blender/blender#119884 2024-03-28 08:27:14 +01:00
Fix #119797: Noise Texture Precision Issues

I'm guessing this gives a measure performance regression. It would be good to understand how big it is. Maybe we'll have to accept it.

@brecht I couldn't measure any performance differences: …

Hoshinova pushed to fix-119797 at Hoshinova/blender 2024-03-27 17:06:45 +01:00
412084ee83 Merge branch 'main' into fix-119797
1984f08250 Fix #119846: EEVEE-Next: Rendering Infinite Samples
880d17e953 -- Overload fmod.
68253b4937 Fix: Cycles volume light tree using wrong point to compute uncertainty angle
3031146097 Fix #119957: Crash when using 'angle constraint' Relative in Knife tool
Compare 114 commits »
Hoshinova commented on pull request blender/blender#119884 2024-03-27 17:06:11 +01:00
Fix #119797: Noise Texture Precision Issues

The noise is still continuous even after this change I think, though not differentiable. So maybe clarify the comment as well.

Since it's cutting a chunk of size 100000.0 out and pasting them…

Hoshinova commented on pull request blender/blender#119884 2024-03-26 13:01:06 +01:00
Fix #119797: Noise Texture Precision Issues

Was the isinf there to fix this same issue?

Maybe, or maybe not. It was added by Brecht in 8cf374d401 (diff-c)…

Hoshinova pushed to fix-119797 at Hoshinova/blender 2024-03-25 17:24:50 +01:00
8cc7115281 -- Fix typo.
Hoshinova created pull request blender/blender#119884 2024-03-25 17:23:23 +01:00
Fix #119797: Noise Texture Precision Issues
Hoshinova pushed to fix-119797 at Hoshinova/blender 2024-03-25 17:18:07 +01:00
763bfa8bc5 -- Fix 119797
b1c85fa78c Fix: Python import error for GPUVertBuf
082b68fcb9 Cycles: improve equiangular sampling in volume
ab93a426a0 Fix assert from recent cleanup
2e8259e4d4 GPv3: Clean loose points in draw mode menu
Compare 10 commits »
Hoshinova created branch fix-119797 in Hoshinova/blender 2024-03-25 17:18:07 +01:00
Hoshinova commented on issue blender/blender#119797 2024-03-25 16:56:10 +01:00
Regression: Black block appears when using some parameters of the Multifractal Noise Texture

So it's highly likely the issue we're seeing in OSL is something precision related in the noise function that Cycles own noise implementation handles better.

Not really, both start to have…

Hoshinova commented on issue blender/blender#119797 2024-03-25 16:45:38 +01:00
Regression: Black block appears when using some parameters of the Multifractal Noise Texture

I can confirm. The issue was introduced in 4.1 between ca9c6372c94c (Sep 28) and 09caf5969010 (Nov 28)

**System Information**
Operating system: Windows-10-10.0.22621-SP0…
Hoshinova approved blender/blender#119287 2024-03-10 18:10:04 +01:00
Fix #119171: show node panels when they have ui even if they don't have sockets
Hoshinova commented on pull request blender/blender#119287 2024-03-10 18:09:38 +01:00
Fix #119171: show node panels when they have ui even if they don't have sockets

It works for me.

Hoshinova opened issue blender/blender#119171 2024-03-07 17:07:45 +01:00
Node panels without sockets disappear, making enums inaccessible.
Hoshinova pushed to noisetex-sockets at Hoshinova/blender 2024-03-06 15:24:03 +01:00
264e11dcd4 -- Fix crash when creating a Noise Texture through dragging and releasing
9bfa17e030 Cleanup: make format.
253a6e36de Core: Library Linking: Add basic tests that linked animation works.
bb00621965 Fix recent regression preventing animation on any linked data.
bfec649bd9 Fix #119043: Compositor crashes with intricate setup
Compare 7 commits »
Hoshinova commented on pull request blender/blender#119097 2024-03-05 21:45:24 +01:00
Fix: Crash when creating Noise Texture node with link-drag-search

I intended it for main branch, but having it in 4.1 doesn't hurt.

Hoshinova created pull request blender/blender#119097 2024-03-05 21:30:29 +01:00
Nodes: Fix crash when creating a Noise Texture through dragging and releasing
Hoshinova created branch noisetex-sockets in Hoshinova/blender 2024-03-05 21:28:50 +01:00
Hoshinova pushed to noisetex-sockets at Hoshinova/blender 2024-03-05 21:28:50 +01:00
c808587492 -- Fix crash when creating a Noise Texture through dragging and releasing
71ff93bb32 Fix: EEVEE-Next: PCF Overshadowing
44d418143e Merge branch 'blender-v4.1-release'
3e09fbf062 Fix #112983: Cycles HIP-RT crash on deleting all objects
e65de74aa5 Cycles: HIP search for ROCm 6 driver
Compare 10 commits »
Hoshinova commented on issue blender/blender#100838 2024-02-27 17:00:16 +01:00
Geometry node - setting lacunarity to 0 crashes Blender (musgrave texture) [fine in 4.1, request to ackport]

Also, since the Musgrave node doesn't exist anymore from 4.1 onward this issue could be seen as resolved.

Hoshinova commented on issue blender/blender#100838 2024-02-27 16:57:20 +01:00
Geometry node - setting lacunarity to 0 crashes Blender (musgrave texture) [fine in 4.1, request to ackport]

@lichtwerk d98005da5d fixes the NAN problem, but only partially. Basically before d98005da5d you'd get NANs for both very low and very high Lacunarity values. d98005da5d fixes the problem for very…