Hoshinova
  • Joined on 2023-04-11
Hoshinova created pull request blender/blender#112962 2023-09-27 16:50:13 +02:00
Fix 112180.
Hoshinova pushed to fix-112180 at Hoshinova/blender 2023-09-27 16:49:11 +02:00
16ba22855d -- Fix bug 112180.
6caa8010d0 Merge branch 'blender-v4.0-release'
03f6fe81b2 Fix: Missing node asset unassigned non-asset label
1a7527b1df Geometry Nodes: Move node tools out of experimental
b5f6c00f0a Merge branch 'blender-v4.0-release'
Compare 10 commits »
Hoshinova created branch fix-112180 in Hoshinova/blender 2023-09-27 16:49:11 +02:00
Hoshinova commented on issue blender/blender#112180 2023-09-27 14:39:29 +02:00
Noise nodes with high detail and lacunarity values outputs erratic values

For the noise and musgrave textures the issues seems to stem from an integer overflow in [floor_fraction](https://projects.blender.org/blender/blender/src/commit/ab26ddc4555bf8cc0c310a46f3f65720894

Hoshinova commented on pull request blender/blender#111187 2023-09-26 17:06:04 +02:00
Nodes: Merge Musgrave Texture Node Into Noise Texture Node

Just to make sure MEM_freeN(node->storage); is enough to free the memory right? No need to tell it how much memory to free etc.?

Hoshinova pushed to merge-noise-nodes2 at Hoshinova/blender 2023-09-26 16:50:48 +02:00
f9332dba07 -- Refix versioning.
Hoshinova pushed to merge-noise-nodes2 at Hoshinova/blender 2023-09-26 16:25:20 +02:00
79ca68984a -- Fix comment
Hoshinova pushed to merge-noise-nodes2 at Hoshinova/blender 2023-09-26 16:19:07 +02:00
724b663574 Merge branch 'main' into merge-noise-nodes2
d0a30654b0 -- Fix versioning.
7dbe689b63 Vulkan: Use Point Shaders When Drawing Points
e4c89baf53 EEVEE-Next: Port subsurface to compute shader
beb90b5573 Cleanup: Make format
Compare 51 commits »
Hoshinova pushed to merge-noise-nodes2 at Hoshinova/blender 2023-09-25 19:41:26 +02:00
fe1c6c7e8d Merge branch 'main' into merge-noise-nodes2
7e0691d027 Fix: Grammar in operator description
9a3131323b UI: About: Update links and labels
f7af45ccfd UI: Splash: Small changes to links and labels
b8c96d1b03 Fix #112059: Anim, Unable to add drivers to bone collections visibility
Compare 23 commits »
Hoshinova pushed to merge-noise-nodes2 at Hoshinova/blender 2023-09-25 14:43:19 +02:00
5b9025fef3 -- Explicilt template instantiation for Wave Texture.
Hoshinova pushed to merge-noise-nodes2 at Hoshinova/blender 2023-09-25 13:18:22 +02:00
26fd38d83f Merge branch 'main' into merge-noise-nodes2
16aad29774 -- Explicitly set function template parameters.
869d0aeaa1 Fix: Cached distortion grids are not reset
8fbfc991a5 Fix: EEVEE-Next: Surfel debug draw
a6d6251b6e Fix #111532: Partial Update Byte Data Texture with Scaling Broken
Compare 36 commits »
Hoshinova commented on pull request blender/blender#111187 2023-09-24 18:46:57 +02:00
Nodes: Merge Musgrave Texture Node Into Noise Texture Node

Does the old node->storage need to be freed?

Hoshinova commented on pull request blender/blender#111187 2023-09-24 17:58:17 +02:00
Nodes: Merge Musgrave Texture Node Into Noise Texture Node

A .blend file for testing the versioning is here: Versioning_Test_File.blend

It was originally created in Blender 3.4 and contains…

Hoshinova commented on pull request blender/blender#111187 2023-09-24 17:36:55 +02:00
Nodes: Merge Musgrave Texture Node Into Noise Texture Node

Unrelated to this PR, but the versioning function below mine 4aaae8d0a6/source/blender/blenloader/intern/versio

Hoshinova commented on pull request blender/blender#111187 2023-09-24 17:32:20 +02:00
Nodes: Merge Musgrave Texture Node Into Noise Texture Node

@OmarEmaraDev @JacquesLucke I've changed the versioning code to not use socket->link->fromnode.

Hoshinova pushed to merge-noise-nodes2 at Hoshinova/blender 2023-09-24 17:28:27 +02:00
b390f8158a Merge branch 'main' into merge-noise-nodes2
ae2647be2a -- Change versioning to not assunme updated links.
4aaae8d0a6 GPencil: Implement nearest neighbor filtering for pixelate effect
b38a61fa07 Cleanup: rename DNA_genfile.h functions
3cd8b531a0 Fix intern/dualcon error in 2721b937fb
Compare 29 commits »
Hoshinova commented on issue blender/blender#112180 2023-09-24 02:00:27 +02:00
Noise nodes with high detail and lacunarity values outputs erratic values

@persun The Voronoi examples are all in Geometry nodes. Is shader nodes Voronoi also affected by this?

You also mentioned that Musgrave has similar issues what input combinations cause Musgrave…

Hoshinova pushed to merge-noise-nodes2 at Hoshinova/blender 2023-09-22 18:28:54 +02:00
5079e83832 -- Refactor versioning_400.cc.
Hoshinova pushed to merge-noise-nodes2 at Hoshinova/blender 2023-09-22 18:00:26 +02:00
32baa9cd53 Merge branch 'main' into merge-noise-nodes2
427bdc8dcf UI: Remove dead space between tree view items
b838c34afa Cleanup: Remove unused sculpt mask expand operator
c6380d772c Fix: Debug build error after recent cleanup
5c9b628596 Fix: Extra period in menu descriptions
Compare 1072 commits »
Hoshinova commented on pull request blender/blender#111187 2023-09-22 17:57:28 +02:00
Nodes: Merge Musgrave Texture Node Into Noise Texture Node

Today marks the historical day were @mod_moder and I agree for once. MEM_cnew will be used instead of MEM_callocN!