Jacques Lucke JacquesLucke
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Jacques Lucke closed issue blender/blender#105571 2023-03-09 11:21:39 +01:00
Regression: Crash: Geometry nodes trying to evaluate cyclic graph
Jacques Lucke pushed to blender-v3.5-release at blender/blender 2023-03-09 11:20:13 +01:00
a4fd2d10c1 Fix #105571: crash when connecting invalid node group to multi input
Jacques Lucke pushed to temp-copy-on-write at JacquesLucke/blender 2023-03-08 14:49:46 +01:00
c358271b03 cleanup
2277944b8e Merge branch 'main' into temp-copy-on-write
6398c9cd7f Cleanup: Remove unused GPU subdivision function declaration
25016b56ef EEVEE Next: Tag shadowmap usage for transparent object volumes
53bb713eda Refactor: Rename OB_GPENCIL and ID_GD
Compare 803 commits »
Jacques Lucke commented on pull request blender/blender#104422 2023-03-08 12:38:31 +01:00
Mesh: Move face shade smooth flag to a generic attribute

This could use a comment about what it is doing at a high level.

Jacques Lucke suggested changes for blender/blender#104422 2023-03-08 12:38:31 +01:00
Mesh: Move face shade smooth flag to a generic attribute

Please double check why one of the tests is failing.

Jacques Lucke commented on pull request blender/blender#104696 2023-03-07 10:58:58 +01:00
Fix and regression test for crash during node group updates

Did you use some other tests as reference here? How to decide what goes into NodeTreeTestContext and what into NodeTreeTest?

Jacques Lucke commented on pull request blender/blender#104696 2023-03-07 10:58:58 +01:00
Fix and regression test for crash during node group updates

Better change ntreeIsRegistered to take a const node tree.

Jacques Lucke commented on pull request blender/blender#104696 2023-03-07 10:58:57 +01:00
Fix and regression test for crash during node group updates

Comment style, missing dot. Same in other places.

Jacques Lucke approved blender/blender#105499 2023-03-07 10:30:22 +01:00
Fix for NaN values resulting from curve editing with collision

Thanks for catching that!

Jacques Lucke commented on pull request blender/blender#105499 2023-03-07 10:30:22 +01:00
Fix for NaN values resulting from curve editing with collision

The name here should contain sq for squared.

Jacques Lucke commented on pull request blender/blender#105464 2023-03-07 10:26:09 +01:00
Blenlib: Add ConstListbaseWrapper for iterating const ListBase *

While this works, I don't always find this better than the macro version. Mainly because it is more verbose and don't add much of a benefit (it doesn't add type safety in this case). I could see this being useful if you want to pass a typed listbase to another function though.

Jacques Lucke commented on pull request blender/blender#105464 2023-03-07 10:26:08 +01:00
Blenlib: Add ConstListbaseWrapper for iterating const ListBase *

Try if using using ListBaseWrapperTemplate<ListBase, T>::ListBaseWrapperTemplate; instead of implementing the constructors again. (not 100% sure if this works here, if it doesn't, ignore this comment)