- Amsterdam
-
Asset system (development lead), UI (developer & module coordindator), VR (initial development).
- Joined on
2013-12-12 -
-
Also, the current PR doesn't handle translation. Disabled hints should use RPT_()
I don't think this needs a new function. Also, memory allocated using new needs freeing, although in modern C++ new in non-library code is a code smell.
That's correct, Blender does intentionally not allow changing assets that are not stored in the current .blend file. With brush assets we started introducing limited support for that, but they…
We should never use the term "ID" in the UI, this is a technical/internal name, it should be "data-block" instead.…
I can't really say much about the Objective-C code, you're much more knowledgeable here so I think I can trust you ;) My review is limited to checking if the code compiles error/warning free and if Blender runs.
Seems fine. Since this is a bit of an unusual versioning check, @mont29 anything against this?
I would still prefer consistently sticking to "Asset Libraries" (as opposed to "Data-block Libraries"), but if this makes things clearer, I'm fine with it. Don't really see a better alternative.
Relying on the order of areas in the screen for a tool system feature is quite weak, and can break easily. Let's not create such hidden logical dependencies. I rather have some explicit heuristics…
I created !126893 to expose the tab when there's a fluid modifier that may use textures. Are there other cases to cover?
I guess covering all these cases, plus only showing brush textures in…