Fix #98014: Preserve tool when exiting full screen area #119856

Open
YimingWu wants to merge 1 commits from ChengduLittleA/blender:fix-98014 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

Since some tools share same brush fields in toolsettings, the tool can
get overwritten when exiting fullscreen and multiple ScrAreas having
different brush settings (like a image editor space could have different
texture paint tool than what is selected in the 3d viewport in texture
paint mode).

This patch fixes the problem by putting the originalScrArea to the
last in screen->areabase, so when exiting fullscreen, the tool gets
preserved since it's always the last one to be set.

Since some tools share same brush fields in `toolsettings`, the tool can get overwritten when exiting fullscreen and multiple `ScrArea`s having different brush settings (like a image editor space could have different texture paint tool than what is selected in the 3d viewport in texture paint mode). This patch fixes the problem by putting the original`ScrArea` to the last in `screen->areabase`, so when exiting fullscreen, the tool gets preserved since it's always the last one to be set.
YimingWu added 1 commit 2024-03-25 03:50:21 +01:00
Since some tools share same brush fields in `toolsettings`, the tool can
get overwritten when exiting fullscreen and multiple `ScrArea`s having
different brush settings (like a image editor space could have different
texture paint tool than what is selected in the 3d viewport in texture
paint mode).

This patch fixes the problem by putting the original`ScrArea` to the
last in `screen->areabase`, so when exiting fullscreen, the tool gets
preserved since it's always the last one to be set.
YimingWu requested review from Pablo Vazquez 2024-03-25 03:50:54 +01:00
YimingWu requested review from Simon Thommes 2024-03-25 03:50:54 +01:00
Simon Thommes approved these changes 2024-03-25 11:42:05 +01:00
Simon Thommes left a comment
Member

Thanks for the fix, works for me!

Would probably be good though to have someone else at least quickly look over it, since I can't do the code review and wouldn't know if there's another preferred way of doing this.

Thanks for the fix, works for me! Would probably be good though to have someone else at least quickly look over it, since I can't do the code review and wouldn't know if there's another preferred way of doing this.
YimingWu requested review from Sergey Sharybin 2024-03-25 12:09:45 +01:00

This isn't really my area.

@JulianEisel is it something you can review?

This isn't really my area. @JulianEisel is it something you can review?
Pratik Borhade requested review from Julian Eisel 2024-04-15 09:19:39 +02:00
Member

@JulianEisel The fix is only a couple of lines, do you think it is the right approach or some other way should be investigated?

@JulianEisel The fix is only a couple of lines, do you think it is the right approach or some other way should be investigated?
Merge conflict checking is in progress. Try again in few moments.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-98014:ChengduLittleA-fix-98014
git checkout ChengduLittleA-fix-98014
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119856
No description provided.