same FATAL_ERROR argument as above.
This may be a controversial opinion, and i do see this may not be everyone's cup of tea but wouldn't mind a a FATAL_ERROR here, something is clearly wrong at this point, and it'd rather know about it sooner than later. Odds of me missing this one in the logs that scroll by at a million miles an hour are much further from 0 than i'd like them to be.
This is rather unhappy on windows
yeah that needs to be if (info.reg.ecx & 0x18000000 == 0x18000000) it's checking the right bits, but isn't validating both are on.
also maybe an oversight in the cycles code not to check…
@G.L can you run the attached executable and share its output?
should be something along the lines of
name : Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz
vendor :…not a full review, got only half way (give or take) also a local build is still running, something will likely shake out of that as well, what i'm saying is, i'll likely ask for more changes in the future.
This bit gives me the Heebie Jeebies, it's so noisy, i'd almost prefer a embree_windows_arm.cmake here, @brecht do you have any strong feelings here?
There's a bit of a mix and match of BLENDER_PLATFORM_ARM and CMAKE_SYSTEM_PROCESSOR MATCHES ARM64 is there a reason for that?
Think it'll be good to know what the plans are at the foundation? are we expected to take over maintenance as this lands, or is this more akin to the linux arm support, couple of patches we don't…
we're not building IGC/ocloc on windows, as they just don't support it and we're forced to use their binary distro, so the builder side changes are essentially a no-op for windows.
We'd…
best to upgrade, even if it's a harmless warn, people reporting on the tracker generally latch on to the first failure they see which in this case is a bit of a red herring