Lorenzo-Carpaneto
  • Joined on 2023-05-31
Lorenzo-Carpaneto pushed to gpv3-select-similar at Lorenzo-Carpaneto/blender 2024-04-14 20:10:51 +02:00
a0b7fde895 gpv3-select-similar
4dcd2ecb03 gpv3-select-similar
05254155d8 gpv3-select-similar
cf4e550bc4 gpv3-select-similar
a7efe3a405 gpv3-select-similar
Compare 4395 commits »
Lorenzo-Carpaneto commented on pull request blender/blender#111410 2024-04-14 19:49:55 +02:00
GPv3: Select Similar operator

I have changed the code as suggested but to me it's not clear how this implementation works. Could you provide a more in detail explanation?

Lorenzo-Carpaneto commented on pull request blender/blender#111410 2024-04-14 19:37:10 +02:00
GPv3: Select Similar operator

I don't get how would this work... I'll publish my changes in a bit, so we can return on this point :)

Lorenzo-Carpaneto commented on pull request blender/blender#111410 2024-04-08 13:30:50 +02:00
GPv3: Select Similar operator

Hello @filedescriptor, I wanted to address the review and I tried contacting you in blender chat for further questions but I did not receive answers. I pinged you on those chats, so if you d like,…

Lorenzo-Carpaneto pushed to gpv3-select-similar at Lorenzo-Carpaneto/blender 2023-12-02 20:10:17 +01:00
9cbfa8f4b3 Merge branch 'main' into gpv3-select-similar
854840b35f VSE: speedup "show overexposed" option
7aa3d967ba Build: update wayland protocols to 1.32
8bb6d0ffe0 Unbreak building with Vulkan & WITH_GHOST_X11=OFF
5b7175c982 GHOST: remove X11 include when WITH_GHOST_X11=11
Compare 4597 commits »
Lorenzo-Carpaneto pushed to gpv3-select-similar at Lorenzo-Carpaneto/blender 2023-09-30 19:33:45 +02:00
6280c5a80d gpv3-select-similar
415d5ae3eb gpv3-select-similar
Compare 2 commits »
Lorenzo-Carpaneto created pull request blender/blender#111410 2023-08-23 00:13:59 +02:00
WIP: gpv3-select-similar
Lorenzo-Carpaneto created branch gpv3-select-similar in Lorenzo-Carpaneto/blender 2023-08-23 00:08:37 +02:00
Lorenzo-Carpaneto pushed to gpv3-select-similar at Lorenzo-Carpaneto/blender 2023-08-23 00:08:37 +02:00
c60f946e63 gpv3-select-similar
6786da323a gpv3-select-similar
a8c29fb221 EEVEE Next: Ensure correct resource usage flags for Metal
5be226699f Fix #109676: GPU compositor crashes on muting output nodes
93c27bf958 Fix #110176: Grey out "Flip" in mirror modifier when "Bisect" is off
Compare 10 commits »
Lorenzo-Carpaneto commented on issue blender/blender#109734 2023-07-18 20:09:57 +02:00
GPv3: Select Similar

If it's not urgent, I would like to pick up this task :)

Lorenzo-Carpaneto pushed to gpv3-select-alternate at Lorenzo-Carpaneto/blender 2023-06-23 11:32:58 +02:00
b6523945bc return early if nothing selected
Lorenzo-Carpaneto pushed to gpv3-select-alternate at Lorenzo-Carpaneto/blender 2023-06-23 11:12:21 +02:00
3569c9d0d2 Remove useless comment
Lorenzo-Carpaneto commented on pull request blender/blender#109240 2023-06-23 11:07:38 +02:00
GPv3: Select Alternate

The check is already there, just forgot the comment :(

Lorenzo-Carpaneto pushed to gpv3-select-alternate at Lorenzo-Carpaneto/blender 2023-06-23 00:45:34 +02:00
465d3d258c loop more readable
Lorenzo-Carpaneto commented on pull request blender/blender#109240 2023-06-23 00:09:59 +02:00
GPv3: Select Alternate

Ah, you are totally right, pushing the proposed version, it's a bit more readable and efficient :)

Lorenzo-Carpaneto commented on pull request blender/blender#109240 2023-06-23 00:01:02 +02:00
GPv3: Select Alternate

According to @SietseB (previous comment in the other thread)

It's weird, but I noticed we can't use points.index_range(), because it always starts at 0. While points.first() gives the…
Lorenzo-Carpaneto commented on pull request blender/blender#109240 2023-06-22 23:54:54 +02:00
GPv3: Select Alternate

@mod_moder @HooglyBoogly I looked better at the problem that @SietseB was saying about IndexRange and I am now convinced that the solution proposed should work :) I have made the change (a bit…

Lorenzo-Carpaneto pushed to gpv3-select-alternate at Lorenzo-Carpaneto/blender 2023-06-22 23:51:55 +02:00
ecaee61f57 Make loop more clear and parallelizable
Lorenzo-Carpaneto commented on pull request blender/blender#109240 2023-06-22 18:29:09 +02:00
GPv3: Select Alternate

We are just discussing about this in the other thread, please join in the dicussion :D

Lorenzo-Carpaneto commented on pull request blender/blender#109240 2023-06-22 18:26:27 +02:00
GPv3: Select Alternate

I was referring to for (const int index : IndexRange(half_of_size))