gpv3-select-similar

First working version. WIP: some things are to be worked on

@@ -28,2 +28,4 @@
 
 namespace blender::ed::greasepencil {
+/* WARNING: don't change existing ones without modifying rearrange func accordingly */
+typedef enum eSelectSimilar {

@@ -286,1 +304,4 @@
 
+static int select_similar_exec(bContext *C, wmOperator *op)
+{
+  const int type = RNA_enum_get(op->ptr, "type");

@@ -287,0 +313,4 @@
+
+  switch (type) {
+    case LAYER:
+      ed::curves::select_similar_layer(

@@ -287,0 +333,4 @@
+          grease_pencil, scene, selection_domain, type, threshold, "opacity");
+      break;
+    default:
+      throw std::invalid_argument("Undefined behavior for eSelectSimilar_Mode " + type);

@@ -287,0 +348,4 @@
+{
+  ot->name = "Select Similar";
+  ot->idname = "GREASE_PENCIL_OT_select_similar";
+  ot->description = "Select all strokes with similar characteristics";

@@ -213,0 +227,4 @@
+  else if constexpr (std::is_same<T, std::string>::value) {
+    return "default";
+  }
+  throw std::invalid_argument("Undefined behavior for distance function for the used type");

@@ -213,0 +278,4 @@
+  return currentlySelectedValues;
+}
+
+template<typename T> static float distance(T first, T second)

@@ -213,0 +300,4 @@
+  VArray<T> attributes = *curves.attributes().lookup_or_default<T>(
+      attribute_id, ATTR_DOMAIN_POINT, default_for_lookup<T>());
+  const OffsetIndices points_by_curve = curves.points_by_curve();
+  bke::GSpanAttributeWriter selection = ensure_selection_attribute(

@@ -213,0 +305,4 @@
+
+  MutableSpan<bool> selection_typed = selection.span.typed<bool>();
+  // for now sequential impl, grain_size == 1
+  threading::parallel_for(curves.curves_range(), 1, [&](const IndexRange range) {

@@ -213,0 +313,4 @@
+        continue;
+      }
+
+      for (const int index : points.index_range()) {

@@ -213,0 +326,4 @@
+  selection.finish();
+}
+
+static void select_similar_layer(GreasePencil &grease_pencil,

@@ -213,0 +371,4 @@
+                           std::string attribute_id)
+{
+  using namespace blender::ed::greasepencil;
+  blender::Vector<blender::Set<T>> currentlySelectedValuesPerDrawing;

@@ -213,0 +383,4 @@
+  Set<T> currentlySelectedValues = join_sets<T>(currentlySelectedValuesPerDrawing);
+
+  threading::parallel_for_each(drawings, [&](const MutableDrawingInfo &info) {
+    blender::ed::curves::select_with_similar_attribute<T>(info.drawing.strokes_for_write(),

@@ -549,6 +549,11 @@ typedef struct GreasePencil {
                              const blender::Map<int, int> &frame_number_destinations,
                              const blender::Map<int, GreasePencilFrame> &duplicate_frames);
 
+  void foreach_editable_drawing_in_layer_ex(