Lukas Stockner LukasStockner
  • Joined on 2013-12-26
Lukas Stockner created branch cycles-kernel-zstd in LukasStockner/blender 2024-06-21 14:38:21 +02:00
Lukas Stockner pushed to cycles-kernel-zstd at LukasStockner/blender 2024-06-21 14:38:21 +02:00
3ec5f91f15 Cycles: Compress GPU kernels to reduce file size
bbf7940d34 Cleanup: Memory leak in UI_OT_eyedropper_depth
56904553ec Cleanup: Rename resample attributes utility struct
48b14f817e Merge branch 'blender-v4.2-release'
aba1a2b6c2 Fix: incorrect grouping of UI props for USD export
Compare 10 commits »
Lukas Stockner commented on issue blender/blender#123522 2024-06-21 13:14:53 +02:00
Cycles: Compress kernel binaries

Just checked, it looks like the OneAPI dynamic library just exposes six functions with C linking? That seems like it should be very simple to dynamically load at runtime. I don't have hardware to…

Lukas Stockner commented on issue blender/blender#123522 2024-06-21 13:03:36 +02:00
Cycles: Compress kernel binaries

Would it be possible to use dlopen or similar to load the OneAPI library at runtime?

Lukas Stockner commented on issue blender/blender#123522 2024-06-21 03:50:50 +02:00
Cycles: Compress kernel binaries

Hm, true. I'll put something together tomorrow, I think getting it into 4.2 is very doable.

Lukas Stockner commented on issue blender/blender#123522 2024-06-21 03:32:10 +02:00
Cycles: Compress kernel binaries

Do we even need a separate script/executable? We could just build the zstd binary as part of the precompiled libraries and invoke that.

I think requiring the zstd binary as a build dependency…

Lukas Stockner commented on issue blender/blender#123522 2024-06-21 02:33:44 +02:00
Cycles: Compress kernel binaries

Hm, that zstd result seems strange to me.

I just downloaded 4.3.0 nightly for Linux and checked, and I get:

  • Uncompressed: 391MB
  • zstd, default: 104MB
  • zstd level 19: 70MB
  • lzma…
Lukas Stockner pushed to main at blender/blender 2024-06-20 22:54:38 +02:00
bbf7940d34 Cleanup: Memory leak in UI_OT_eyedropper_depth
Lukas Stockner commented on pull request blender/blender#123278 2024-06-20 21:52:21 +02:00
Color management: Support white balance as part of the display transform

Update:

  • Fix property capitalization
  • Add preset support
  • Add presets for all CIE illuminants
  • Improve comments
  • Support prop_data_path in UI_OT_eyedropper_color
  • Add eyedropper…
Lukas Stockner pushed to white-balance at LukasStockner/blender 2024-06-20 21:51:10 +02:00
fc04eb4c34 Add Eyedropper operator to panel header
8f887212d7 Support prop_data_path in color eyedropper
258a135a64 Expand comments
1a4aa63b5a Add presets for CIE Illuminants
ae8dff32cc Fix capitalization
Compare 5 commits »
Lukas Stockner pushed to main at blender/blender-developer-docs 2024-06-20 20:55:08 +02:00
5ad56b6cfa 4.3: Viewport color picking
Lukas Stockner commented on pull request blender/blender#123278 2024-06-20 20:30:55 +02:00
Color management: Support white balance as part of the display transform

The restriction in range is intentional, +-150 tint (technically +- 0.05 delta_uv, but that's the same) is the official CIE threshold for whether expressing a color as a temperature is meaningful.…

Lukas Stockner commented on pull request blender/blender#123278 2024-06-20 00:12:41 +02:00
Color management: Support white balance as part of the display transform

Okay, I got the color picking inversion working, and it changes the existing code enough that updating this PR makes more sense than creating a follow-up.

Panel names are also changed.

@blend…

Lukas Stockner pushed to white-balance at LukasStockner/blender 2024-06-20 00:11:52 +02:00
3ab6107a64 Remove "Use " from subpanels
85d9405d7b Implement white point picking
0ef7f3448f Mark input as color temperature
79ec99c3e7 Bump subversion
7c359b6ece Transpose matrix before passing to OCIO
Compare 88 commits »
Lukas Stockner pushed to white-balance at LukasStockner/blender 2024-06-19 18:43:42 +02:00
6d2d3acde8 Mark input as color temperature
Lukas Stockner commented on pull request blender/blender#123278 2024-06-19 18:10:58 +02:00
Color management: Support white balance as part of the display transform

Turns out that OCIO expects row-major matrices, so a transpose was missing. Output matches now.

Lukas Stockner pushed to white-balance at LukasStockner/blender 2024-06-19 18:10:33 +02:00
e5741f7a07 Bump subversion
ed51a94c11 Transpose matrix before passing to OCIO
02cc66e8d0 Remove debug print
Compare 3 commits »
Lukas Stockner commented on pull request blender/blender#123278 2024-06-19 17:35:18 +02:00
Color management: Support white balance as part of the display transform

Right, I had skipped it for the initial PR since it probably would have been outdated by the end. I'll add it now.

Lukas Stockner deleted branch viewport-color-pick from LukasStockner/blender 2024-06-19 17:28:10 +02:00