Lukas Stockner LukasStockner
17 Followers · 0 Following
  • Joined on 2013-12-26
Repositories
5
 Projects Public Activity Starred Repositories
Lukas Stockner created branch remove-transmission-roughness in LukasStockner/blender 2023-07-11 02:48:43 +02:00
Lukas Stockner pushed to remove-transmission-roughness at LukasStockner/blender 2023-07-11 02:48:43 +02:00
f0ead2eac5 Cycles: Remove Transmission Roughness from Principled BSDF
Lukas Stockner created pull request blender/blender#109949 2023-07-11 02:25:49 +02:00
WIP: Replace Sheen model in the Principled BSDF
Lukas Stockner created branch sheen-principled in LukasStockner/blender 2023-07-11 02:24:44 +02:00
Lukas Stockner pushed to sheen-principled at LukasStockner/blender 2023-07-11 02:24:44 +02:00
222f4e5ba3 Replace Sheen model in the Principled BSDF
Lukas Stockner commented on pull request blender/blender#108869 2023-07-11 02:21:16 +02:00
Cycles: Update Velvet BSDF to Sheen BSDF with new Microfiber sheen model

Okay, I've pushed a rework of the PR that replaces the WIP implementations of both models with just an implementation of the LTC-based model, plus the versioning code etc.

For naming the enum…

Lukas Stockner pushed to sheen at LukasStockner/blender 2023-07-11 02:14:46 +02:00
df669b77ed Cycles: Update Velvet BSDF to Sheen BSDF with new Microfiber sheen model
3046b0a19e CMake: Fix shader_builder build error
6d74a7173e Cleanup: Remove unused function
5ca29d293b Fix: BLI: Assert in generic array move constructor
04235d0e55 Cleanup: CMake: Modernize bf_blenlib dependencies
Compare 683 commits »
Lukas Stockner pushed to main at LukasStockner/blender 2023-07-11 02:14:39 +02:00
3046b0a19e CMake: Fix shader_builder build error
6d74a7173e Cleanup: Remove unused function
5ca29d293b Fix: BLI: Assert in generic array move constructor
04235d0e55 Cleanup: CMake: Modernize bf_blenlib dependencies
093a4d63f3 Cleanup: Move some space_view3d files to C++
Compare 777 commits »
Lukas Stockner approved blender/blender#109902 2023-07-11 02:13:37 +02:00
Cleanup: Cycles: remove SHARP distribution internally

Overall LGTM, just two comments.

Lukas Stockner commented on pull request blender/blender#109902 2023-07-11 02:13:36 +02:00
Cleanup: Cycles: remove SHARP distribution internally

reflection() and refraction() are default builtin closures in OSL, so we probably want to keep this closure in the OSL interface. We can just implement it through bsdf_microfacet_ggx_setup() I guess.

Lukas Stockner commented on pull request blender/blender#109902 2023-07-11 02:13:36 +02:00
Cleanup: Cycles: remove SHARP distribution internally

This if block is repeated seven times, it might be worth adding something like

Lukas Stockner pushed to principled at LukasStockner/blender 2023-07-09 03:51:03 +02:00
e1ada94395 Implement layering in Principled BSDF (TODO: only OSL so far)
2284d78d2a Implement layer() in OSL
5428cb5499 Remove principled_clearcoat
08cfe20762 Remove principled_diffuse
8cadb9ac58 Switch Principled back to regular diffuse
Compare 10 commits »
Lukas Stockner created branch principled in LukasStockner/blender 2023-07-09 03:51:03 +02:00
Lukas Stockner commented on pull request blender/blender#108869 2023-06-17 03:39:05 +02:00
Cycles: Update Velvet BSDF to Sheen BSDF with new Microfiber sheen model

Hi @Tizian-Zeltner, thanks for checking this, glad to hear that the implementation looks good!

The patch is updated for OSL now, I'll run a build so people can try it out. But yeah, I'm also…

Lukas Stockner pushed to sheen at LukasStockner/blender 2023-06-17 03:33:32 +02:00
094f9ad111 Cycles: Add two new Sheen BSDFs to the Velvet node
a53eb4a560 Merge branch 'blender-v3.6-release'
a6931db38b Fix: Build error without OpenEXR
3550eb3d46 Merge branch 'blender-v3.6-release'
17aaff69c6 Fix #109043: Mask modifier smooth option broken
Compare 252 commits »
Lukas Stockner deleted branch fix-indirect-baking-mis from LukasStockner/blender 2023-06-16 03:03:33 +02:00
Lukas Stockner pushed to main at blender/blender 2023-06-16 03:03:33 +02:00
a783fe8198 Cycles: Fix some direct lighting leaking into indirect-only bakes
Lukas Stockner merged pull request blender/blender#108955 2023-06-16 03:03:32 +02:00
Cycles: Fix some direct lighting leaking into indirect-only bakes
Lukas Stockner commented on pull request blender/blender#108996 2023-06-16 02:11:54 +02:00
Cycles: Change sun lamp to have uniform intensity at high angles

Okay, I've updated the PR. As far as I can tell, it behaves correctly for small angles (on the order of 0.01°) now.

For those angles, the previous dot(a, b) < cos(angle) actually becomes an…

Lukas Stockner pushed to uniform-distant-light at LukasStockner/blender 2023-06-16 02:02:25 +02:00
4a6b9c3b08 Use more precise math for the cone angle