WIP: New component type: cloud_curve_custom #160

tone-watson · 2024-08-07T17:22:35+02:00

tone-watson commented

2024-08-07 17:22:35 +02:00

First-time contributor

@demeter i needed a spline ik curve but i needed the radii on the curve to be set manually, cloud_curve_custom is just a clone of cloud_spline_ik with the driver generation removed from setup_spline and a modified reset_curve_obj to store the radii of the curve before regenerating it so they can be applied again. would also be cool if you'd prefer to instead have an option like in Curve Spline IK to achieve this, i'd be happy to make that update too if you want.

would probably need to remove cls.draw_prop(context, layout, params.curve, "separate_radius") from the panel, i can do that too if you have a direction for this

@demeter i needed a spline ik curve but i needed the radii on the curve to be set manually, cloud_curve_custom is just a clone of cloud_spline_ik with the driver generation removed from `setup_spline` and a modified `reset_curve_obj` to store the radii of the curve before regenerating it so they can be applied again. would also be cool if you'd prefer to instead have an option like in Curve Spline IK to achieve this, i'd be happy to make that update too if you want. would probably need to remove `cls.draw_prop(context, layout, params.curve, "separate_radius")` from the panel, i can do that too if you have a direction for this

Screenshot 2024-08-07 at 10.22.09 AM.png

625 KiB

tone-watson added 1 commit 2024-08-07 17:22:39 +02:00

New component type: cloud_curve_custom db9638416e

tone-watson changed title from ~~New component type: cloud_curve_custom~~ to WIP: New component type: cloud_curve_custom

2024-08-07 17:22:53 +02:00

tone-watson force-pushed feature/curve-custom from db9638416e to a2c32490df

2024-08-09 02:33:47 +02:00

Compare

Demeter Dzadik commented

2024-08-11 02:53:16 +02:00

Hey there!

Can you talk a bit more about your use case? I feel like the intended use here would be to convert your object to a mesh, then rig it to the Spline IK bones, in which case the initial radius values won't matter anymore. On the flipside, if you don't want to convert it to a mesh, then I don't think you're getting any extra benefit from the Spline IK component type, and you could just use the regular Curve component type instead, although that will also drive the radius value.

But if I'm right, that would mean just adding a param to not drive the radius in cloud_curve.py, and you'd be covered. That would also be inherited by cloud_spline_ik.py, if you need that for any reason.

Hey there! Can you talk a bit more about your use case? I feel like the intended use here would be to convert your object to a mesh, then rig it to the Spline IK bones, in which case the initial radius values won't matter anymore. On the flipside, if you don't want to convert it to a mesh, then I don't think you're getting any extra benefit from the Spline IK component type, and you could just use the regular Curve component type instead, although that will also drive the radius value. But if I'm right, that would mean just adding a param to not drive the radius in cloud_curve.py, and you'd be covered. That would also be inherited by cloud_spline_ik.py, if you need that for any reason.

tone-watson commented

2024-08-13 03:29:48 +02:00

First-time contributor

hahaha you're exactly right, that was what i ended up doing. there is still a part of me that thinks an option to turn the scale drivers on and off could be helpful for the Curve: Spline IK, because the autogeneration of the curve obj is super nice. but I'm with you in that i can't think of a direct use case rn so i'm closing this

Super appreciate everything you're doing on this

hahaha you're exactly right, that was what i ended up doing. there is still a part of me that thinks an option to turn the scale drivers on and off could be helpful for the Curve: Spline IK, because the autogeneration of the curve obj is super nice. but I'm with you in that i can't think of a direct use case rn so i'm closing this Super appreciate everything you're doing on this

❤️ 1

tone-watson closed this pull request

2024-08-13 03:29:49 +02:00