Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim deleted branch remove-extra-undo-data-geometry-push from Sean-Kim/blender 2024-11-14 02:08:15 +01:00
Sean Kim merged pull request blender/blender#129828 2024-11-14 02:08:03 +01:00
Refactor: Sculpt: Avoid storing extra undo data on geometry_push
Sean Kim pushed to main at blender/blender 2024-11-14 02:08:03 +01:00
6b7ba4c726 Refactor: Sculpt: Avoid storing extra undo data on geometry_push
Sean Kim commented on pull request blender/blender#130248 2024-11-14 00:50:26 +01:00
Fix #128798: Face corner normals cache not tagged dirty in sculpt undo

I don't understand why we do this if !tag_update - is it because in the tag_update case we dont have a mesh.runtime->corner_normals_cache to worry about?

Sean Kim pushed to remove-extra-undo-data-geometry-push at Sean-Kim/blender 2024-11-14 00:27:40 +01:00
294c308767 Rename, add comment
Sean Kim commented on pull request blender/blender#130058 2024-11-12 02:01:26 +01:00
Fix #125787: Relative texture paths do not work with brush assets

@mont29 Could you take a look at this soon? Wanted to get this fix merged in before the 4.3 RC if possible.

Sean Kim pushed to fix-texture-load-relative-path at Sean-Kim/blender 2024-11-12 01:59:46 +01:00
0c4fff7304 Reorder functions
Sean Kim commented on issue blender/blender#110879 2024-11-12 01:22:59 +01:00
Multires: Subdivision Set Relative is subdividing the object

So I was looking at this recently for some other related changes; while I agree that having the behavior depend on relative is weird, adding subdivide also as a parameter seems that it would…

Sean Kim closed pull request blender/blender#130017 2024-11-12 00:47:45 +01:00
WIP: Add support for multiple brush types per tool
Sean Kim commented on pull request blender/blender#130017 2024-11-12 00:47:43 +01:00
WIP: Add support for multiple brush types per tool

Closing this, this approach is unlikely to be taken with more time to look into the root cause.

Sean Kim deleted branch cleanup-clang-format from Sean-Kim/blender 2024-11-12 00:44:51 +01:00
Sean Kim merged pull request blender/blender#130158 2024-11-12 00:44:47 +01:00
ClangFormat: Remove unused sculpt macro exceptions
Sean Kim pushed to main at blender/blender 2024-11-12 00:44:47 +01:00
bdee3b9762 ClangFormat: Remove unused sculpt macro exceptions
Sean Kim commented on issue blender/blender#128659 2024-11-12 00:43:00 +01:00
The new Paint tool in Sculpt mode doesn't filter brushes with the Smear type

Bumping this from the 4.3 milestone. Unfortunately with RC coming up any change to fix this would be relatively large and likely too risky to actually attempt before the release.

Sean Kim pushed to remove-extra-undo-data-geometry-push at Sean-Kim/blender 2024-11-12 00:03:30 +01:00
8f804884b4 PR Feedback
Sean Kim commented on pull request blender/blender#130158 2024-11-11 23:24:22 +01:00
ClangFormat: Remove unused sculpt macro exceptions
Sean Kim created pull request blender/blender#130158 2024-11-11 23:23:25 +01:00
ClangFormat: Remove unused sculpt macro exceptions