Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on issue blender/blender#120628 2024-06-19 22:19:16 +02:00
Transfer Sculpt Mode flickering artefacts

Looking into this one. Broken in 4.0.1 as well

Sean Kim approved blender/blender#123428 2024-06-19 21:47:40 +02:00
Fix #123181: Sculpt Transform tools dont keep verts on the symmetry axis

Appears to work the same in Edit mode and Sculpt mode now, no code comments from me, though I agree with Iliya and Hans on the constexpr

Sean Kim approved blender/blender#123231 2024-06-19 21:23:34 +02:00
Sculpt: Initial data oriented refactor for crease/blob brushes

Re-tested, everything's looking good now

Sean Kim deleted branch face-set-create-api from Sean-Kim/blender 2024-06-19 21:18:41 +02:00
Sean Kim pushed to main at blender/blender 2024-06-19 21:18:38 +02:00
d908ae7fcc Refactor: Add helper method for creating face set attribute
Sean Kim merged pull request blender/blender#123401 2024-06-19 21:18:37 +02:00
Refactor: Add helper method for creating face set attribute
Sean Kim deleted branch array-include-mesh-brush-commons from Sean-Kim/blender 2024-06-19 02:35:16 +02:00
Sean Kim pushed to main at blender/blender 2024-06-19 02:35:14 +02:00
ea90d3f409 Cleanup: Add BLI_array.hh to includes for common brush code
Sean Kim merged pull request blender/blender#123407 2024-06-19 02:35:14 +02:00
Cleanup: Add BLI_array.hh to includes for common brush code
Sean Kim suggested changes for blender/blender#123231 2024-06-19 02:22:08 +02:00
Sculpt: Initial data oriented refactor for crease/blob brushes

Issues I found with testing:

Sean Kim created pull request blender/blender#123407 2024-06-19 01:52:49 +02:00
Cleanup: Add BLI_array.hh to includes for common brush code
Sean Kim created branch array-include-mesh-brush-commons in Sean-Kim/blender 2024-06-19 01:52:14 +02:00
Sean Kim pushed to array-include-mesh-brush-commons at Sean-Kim/blender 2024-06-19 01:52:14 +02:00
6302944464 Cleanup: Add BLI_array.hh to includes for common brush code
6bb978d07d Fix #123382: Subdivision surface crash with no faces
8ac66b1c8e Cleanup: Add comments for StrokeCache variables
97b06c429f Cycles: Fix multiscattering Oren-Nayar at glancing angles, update tests
Compare 4 commits »
Sean Kim deleted branch add-stroke-cache-comments from Sean-Kim/blender 2024-06-19 01:03:52 +02:00
Sean Kim pushed to main at blender/blender 2024-06-19 01:03:49 +02:00
8ac66b1c8e Cleanup: Add comments for StrokeCache variables
Sean Kim merged pull request blender/blender#123402 2024-06-19 01:03:49 +02:00
Cleanup: Add comments for StrokeCache variables
Sean Kim suggested changes for blender/blender#123154 2024-06-19 00:36:35 +02:00
Sculpt: Initial data oriented refactor for clay strips brush

Tested against the files in tests/data/sculpting - noticed that for shape_keys.blend, the current patch doesn't seem to affect the mesh.

Sean Kim commented on issue blender/blender#123349 2024-06-18 23:06:48 +02:00
Regression: Incorrect initialization of face sets by material

Assumed this was related to a different bug I looked at recently - unassigning myself for now since it seems unrelated.

Sean Kim created pull request blender/blender#123402 2024-06-18 22:29:52 +02:00
Cleanup: Add comments for StrokeCache variables