Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#120282 2024-05-28 05:49:41 +02:00
Sculpt: Add increase / decrease visibility operator
Sean Kim pushed to hide-show-grow-shrink at Sean-Kim/blender 2024-05-28 05:49:16 +02:00
2ac7e8e236 Remove buffer equality check
Sean Kim pushed to hide-show-grow-shrink at Sean-Kim/blender 2024-05-28 05:30:16 +02:00
6bcb5fa30c Merge branch 'main' of projects.blender.org:blender/blender into hide-show-grow-shrink
91c7809640 Fix #122319: GPU subdivision loose geometry positions invalid
74c3d0aec9 Simplify update_undo_state
4f12082d8b Use imperative tense for user-facing descriptions
242d949f90 Rename function
Compare 252 commits »
Sean Kim commented on pull request blender/blender#120282 2024-05-28 05:20:36 +02:00
Sculpt: Add increase / decrease visibility operator

I did some testing, without this equality check across about ~150 runs of the operator on a mesh with 1.5m verts, the average is about 90ms, compared to 96ms when doing the check. I don't…

Sean Kim commented on pull request blender/blender#120282 2024-05-28 04:56:53 +02:00
Sculpt: Add increase / decrease visibility operator

I'm not sure what you mean by using vert_hide_update here - do you mean swapping out the propagate_vertex_visbility and update_undo_state functions for it? I think it's possible but adapting…

Sean Kim commented on pull request blender/blender#120282 2024-05-28 04:29:26 +02:00
Sculpt: Add increase / decrease visibility operator

Yep, makes sense. I'm still not super solid on move semantics but it's good to keep in mind.

Sean Kim commented on pull request blender/blender#120282 2024-05-28 04:17:00 +02:00
Sculpt: Add increase / decrease visibility operator

Oh, good to know. I wasn't aware that that's how TBB operated

Sean Kim commented on pull request blender/blender#120282 2024-05-28 04:05:41 +02:00
Sculpt: Add increase / decrease visibility operator

Realistically, it only happens when you're hiding a mesh that's already mostly hidden or showing a mesh that's already mostly visible. I didn't measure the impact of removing this and just letting…

Sean Kim commented on pull request blender/blender#120282 2024-05-28 03:59:00 +02:00
Sculpt: Add increase / decrease visibility operator

Isn't IndexRange face still needed for face_corner_prev & face_corner_next?

Sean Kim pushed to main at blender/blender-developer-docs 2024-05-28 03:40:44 +02:00
97b219cd32 VSCode: Add GitLens integration instructions with projects.blender.org
Sean Kim merged pull request blender/blender-developer-docs#59 2024-05-28 03:40:38 +02:00
VSCode: Add GitLens integration instructions with projects.blender.org
Sean Kim commented on pull request blender/blender#122248 2024-05-25 22:36:37 +02:00
Sculpt: Add Polyline Mask, Face Set, and Trim

@blender-bot package

Sean Kim pushed to polyline-gestures at Sean-Kim/blender 2024-05-25 22:36:06 +02:00
b821a6a6d3 Update polyline_face_set icon
Sean Kim commented on pull request blender/blender-assets#6 2024-05-25 22:30:39 +02:00
Fix: Correct polyline hide and polyline face set icons

Updated to incorporate color fixes for ops.sculpt.polyline_face_set from @nickberckley

Sean Kim pushed to fix-polyline-mask at Sean-Kim/blender-assets 2024-05-25 22:20:55 +02:00
a69fb9eb2b Fix ops.sculpt.polyline_face_set color
Sean Kim commented on pull request blender/blender#122248 2024-05-25 06:24:52 +02:00
Sculpt: Add Polyline Mask, Face Set, and Trim

@blender-bot package

Sean Kim created pull request blender/blender#122248 2024-05-25 06:24:17 +02:00
Sculpt: Add Polyline Mask, Face Set, and Trim
Sean Kim created branch polyline-gestures in Sean-Kim/blender 2024-05-25 06:16:36 +02:00
Sean Kim pushed to polyline-gestures at Sean-Kim/blender 2024-05-25 06:16:36 +02:00
7fb148a211 Sculpt: Add Polyline Mask, Face Set, and Trim
Sean Kim created pull request blender/blender-assets#6 2024-05-25 04:31:11 +02:00
Fix: Ensure Polyline Mask icon is visible after rendering