Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:53 +02:00
Sculpt: Start data-oriented refactor for draw brush

How about we add a new namespace here for brushes?

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:51 +02:00
Sculpt: Start data-oriented refactor for draw brush

Documentation for both of these methods? Maybe just something about the difference between the regular draw_brush and draw_vector_displacement_brush?

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:50 +02:00
Sculpt: Start data-oriented refactor for draw brush

Same assert as above

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:49 +02:00
Sculpt: Start data-oriented refactor for draw brush

Same assert as above

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:48 +02:00
Sculpt: Start data-oriented refactor for draw brush

BLI_assert(translations.size() == verts.size()) here?

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:47 +02:00
Sculpt: Start data-oriented refactor for draw brush

Should this be span[verts[i]] instead? I don't see what's the point of line 6311 otherwise.

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:46 +02:00
Sculpt: Start data-oriented refactor for draw brush

Apply the same BLI_assert as above in this function?

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:45 +02:00
Sculpt: Start data-oriented refactor for draw brush

r_ prefixes in this file for return args

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:44 +02:00
Sculpt: Start data-oriented refactor for draw brush

We're going to have this switch statement repeated a fair amount across the brushes as we migrate them, do you think there's a common abstract class we could extract for the different PBVH types and their respective calc_ methods?

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:43 +02:00
Sculpt: Start data-oriented refactor for draw brush

Is it worth changing this to float3 and float r_rgba[4] to float4 in this PR?

Sean Kim commented on pull request blender/blender#121835 2024-05-16 01:10:42 +02:00
Sculpt: Start data-oriented refactor for draw brush

Documentation

Sean Kim deleted branch workspace-api-doc from Sean-Kim/blender 2024-05-15 23:22:08 +02:00
Sean Kim merged pull request blender/blender#121810 2024-05-15 23:22:05 +02:00
Cleanup: Add API docs for new WorkspaceStatus methods
Sean Kim pushed to main at blender/blender 2024-05-15 23:22:05 +02:00
5a3fee92a5 Cleanup: Add API docs for new WorkspaceStatus methods
Sean Kim created pull request blender/blender#121810 2024-05-15 00:09:04 +02:00
Cleanup: Add API docs for new WorkspaceStatus methods
Sean Kim created branch workspace-api-doc in Sean-Kim/blender 2024-05-15 00:04:31 +02:00
Sean Kim pushed to workspace-api-doc at Sean-Kim/blender 2024-05-15 00:04:31 +02:00
9c2273551c Cleanup: Add API docs for new WorkspaceStatus methods
1589f3713a Fix: EEVEE-Next: Fix Shadow resolution limit step
41bbbd2359 UI: Color Tooltips
92e0545e9f UI: Remove BLF_draw_default_shadowed
68de483bf3 Fix: Ray Portal BSDF changing sd->flag when closure is not allocated
Compare 10 commits »
Sean Kim created pull request blender/blender-developer-docs#59 2024-05-14 21:36:07 +02:00
VSCode: Add GitLens integration instructions with projects.blender.org
Sean Kim deleted branch fix-120761-option-2 from Sean-Kim/blender 2024-05-14 21:25:14 +02:00
Sean Kim pushed to main at blender/blender 2024-05-14 21:25:13 +02:00
7017091272 Fix #120761: Handle vert to face flushing in vert_hide_update