Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#121678 2024-05-14 01:42:44 +02:00
Fix #120761: Handle vert to face flushing in vert_hide_update

Actually, we need the index_range() here because this is following the same scatter / gather pattern that's used in the other callbacks like calc_hide - node_faces and hide_face are…

Sean Kim commented on pull request blender/blender#121678 2024-05-13 22:02:10 +02:00
Fix #120761: Handle vert to face flushing in vert_hide_update

Whoops, yeah that's definitely a better option. Will do.

Sean Kim closed pull request blender/blender#120798 2024-05-11 01:39:57 +02:00
Fix #120761: Tag all PBVH nodes for needing a visibility update when using hide tools
Sean Kim commented on pull request blender/blender#120798 2024-05-11 01:39:55 +02:00
Fix #120761: Tag all PBVH nodes for needing a visibility update when using hide tools

Closing this PR in favor of the newer one linked above.

Sean Kim created pull request blender/blender#121678 2024-05-11 01:39:06 +02:00
Fix #120761: Handle vert to face flushing in vert_hide_update
Sean Kim pushed to fix-120761-option-2 at Sean-Kim/blender 2024-05-11 01:30:19 +02:00
ba32739de7 Fix #120761: Handle vert to face flushing in vert_hide_update
Sean Kim created branch fix-120761-option-2 in Sean-Kim/blender 2024-05-11 01:30:19 +02:00
Sean Kim pushed to more-timeit-stats at Sean-Kim/blender 2024-05-10 22:23:40 +02:00
45eceebb74 Remove max stat
Sean Kim commented on pull request blender/blender#121638 2024-05-10 03:54:26 +02:00
BLI: Add count to timeit ScopedTimerAveraged

Adding the number of samples makes sense, but I don't think the max is very meaningful honestly. That's so dependent on whether the operating system decided to schedule some other task at the…

Sean Kim created pull request blender/blender#121638 2024-05-10 02:21:47 +02:00
BLI: Add max and count to timeit ScopedTimer
Sean Kim pushed to more-timeit-stats at Sean-Kim/blender 2024-05-10 02:20:01 +02:00
856a17bd3e BLI: Add max and count to timeit ScopedTimer
Sean Kim pushed to more-timeit-stats at Sean-Kim/blender 2024-05-10 02:16:54 +02:00
019708e4b5 Core: Add max and count to timeit ScopedTimer
b773eca1b5 IO: Use panels for Alembic, OBJ, PLY, and STL
d089b5e6ad Fix #121432: Rework collection exporter UI to prevent panel id collisions
9fcf97d978 Geometry Nodes: support matrix in Transform Geometry node
675d429597 Fix #121546: Ensure face set exists before trim operation
Compare 10 commits »
Sean Kim created branch more-timeit-stats in Sean-Kim/blender 2024-05-10 02:16:54 +02:00
Sean Kim commented on pull request blender/blender#120282 2024-05-09 21:49:00 +02:00
Sculpt: Add increase / decrease visibility operator

Hi. Is this already in master?

Amazing work. Thank you.

Not yet, this is still pending code review.

Sean Kim pushed to main at blender/blender 2024-05-09 21:22:52 +02:00
675d429597 Fix #121546: Ensure face set exists before trim operation
Sean Kim deleted branch fix-121546 from Sean-Kim/blender 2024-05-09 21:22:51 +02:00
Sean Kim closed issue blender/blender#121546 2024-05-09 21:22:50 +02:00
Regression: Sculpt: Trim tools not creating face sets automatically
Sean Kim merged pull request blender/blender#121604 2024-05-09 21:22:48 +02:00
Fix #121546: Ensure face set exists before trim operation
Sean Kim pushed to fix-121546 at Sean-Kim/blender 2024-05-09 20:36:10 +02:00
383c7ca287 Further feedback
Sean Kim pushed to fix-121546 at Sean-Kim/blender 2024-05-09 20:21:47 +02:00
b2a7b6faba PR feedback