Will do, I was on the fence about adding them, but I decided to keep it in the PR when submitting just to err on the side of more rather than less.
Just to be clear - do you mean the general restructuring that happened in the cache_init
function, or just the added comments?
Oh, makes sense - I got a bit confused with seeing some of the previous changes in this file that do both. I assumed that it was a prerequisite to have both layers of checks.
Planning on picking up this work at some point soon since this seems to have stalled out in the last year.
Tagging @Sergey @HooglyBoogly and @JulienKaspar as specific in the original issue for review.
@JulienKaspar So, I think I've found a bit of a wrinkle in the proposed plan. By moving this data to UnifiedPaintSettings
there's a bit of flexibility that the current implementation allows that…