Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim commented on issue blender/blender#115174 2024-01-23 00:54:52 +01:00
Auto-Masking Limit and Falloff not a brush setting

Picking this task up, should have a PR later this week

Sean Kim commented on pull request blender/blender#117316 2024-01-20 00:59:26 +01:00
Sculpt: Add global automasking propagation steps

Sorry that I'm being a bit picky about removing unrelated changes from this PR, but I think it's a good habit to get into, and it makes the life of anyone reading the diff later easier.

No…

Sean Kim pushed to 102377-auto-masking at Sean-Kim/blender 2024-01-20 00:57:07 +01:00
4aed7e3b00 Remove exists check and unrelated changes
Sean Kim commented on pull request blender/blender#117316 2024-01-20 00:51:19 +01:00
Sculpt: Add global automasking propagation steps

Whoops, thought I removed this in the previous commit

Sean Kim pushed to 108109-unified-input-samples at Sean-Kim/blender 2024-01-20 00:42:37 +01:00
65c312aaa1 Address CR comments
3c888eefc4 Merge branch 'main' of projects.blender.org:blender/blender into 108109-unified-input-samples
33bb3d838f Fix #117224: Outliner recursive selection fails in reverse order
d2e4da0f5b Cleanup: reduce C-isms in imbuf headers
a705259b4b Cleanup: move imbuf .h files to .hh
Compare 139 commits »
Sean Kim pushed to 102377-auto-masking at Sean-Kim/blender 2024-01-20 00:30:02 +01:00
bc0b22946d Bump subversion correctly
Sean Kim pushed to 102377-auto-masking at Sean-Kim/blender 2024-01-20 00:21:06 +01:00
db184fd490 Address CR comments
346eac756b Merge branch 'main' of projects.blender.org:blender/blender into 102377-auto-masking
33bb3d838f Fix #117224: Outliner recursive selection fails in reverse order
d2e4da0f5b Cleanup: reduce C-isms in imbuf headers
a705259b4b Cleanup: move imbuf .h files to .hh
Compare 62 commits »
Sean Kim commented on issue blender/blender#102377 2024-01-19 21:52:21 +01:00
Auto-Masking: Propagation Steps needed as a global setting

Unsure why gitea didnt link the related PR automatically, but it's here: #117316

Sean Kim commented on pull request blender/blender#117080 2024-01-19 21:50:41 +01:00
Sculpt: Add per-brush input samples

That seems like it would add more logic onto the python side of things to handle this instead of using the pattern that already exists for the UnifiedPaintSettings, and I think that having the…

Sean Kim commented on pull request blender/blender#117080 2024-01-19 21:42:15 +01:00
Sculpt: Add per-brush input samples

Will do, I was on the fence about adding them, but I decided to keep it in the PR when submitting just to err on the side of more rather than less.

Sean Kim commented on pull request blender/blender#117316 2024-01-19 21:39:45 +01:00
Sculpt: Add global automasking propagation steps

Just to be clear - do you mean the general restructuring that happened in the cache_init function, or just the added comments?

Sean Kim commented on pull request blender/blender#117316 2024-01-19 21:37:42 +01:00
Sculpt: Add global automasking propagation steps

Oh, makes sense - I got a bit confused with seeing some of the previous changes in this file that do both. I assumed that it was a prerequisite to have both layers of checks.

Sean Kim created pull request blender/blender#117316 2024-01-19 06:39:35 +01:00
Sculpt: Add global automasking propagation steps
Sean Kim pushed to 102377-auto-masking at Sean-Kim/blender 2024-01-19 06:38:08 +01:00
619e6d440a Sculpt: Add global automasking propagation steps
Sean Kim pushed to 102377-auto-masking at Sean-Kim/blender 2024-01-19 03:38:17 +01:00
961183a5a2 Sculpt: Add global automasking propagation steps
Sean Kim created branch 102377-auto-masking in Sean-Kim/blender 2024-01-19 03:31:46 +01:00
Sean Kim pushed to 102377-auto-masking at Sean-Kim/blender 2024-01-19 03:31:46 +01:00
de6a8e5839 Sculpt: Add global automasking propagation steps
f7f3460231 Cleanup: various non-functional changes for C++
3fe1097d24 Cleanup: lazily import bpy_extras.object_utils where possible
f4e52f447a Modifiers: add ModifierTypeInfo::foreach_cache callback
d25274ee63 Cleanup: rename IDCacheKey.offset_in_ID to identifier
Compare 10 commits »
Sean Kim pushed to 108109-unified-input-samples at Sean-Kim/blender 2024-01-17 03:59:25 +01:00
7ebb780257 Rebase on main reapply and fix versioning changes
5b03b51dcc Sculpt: Add per-brush input samples
a2032a9aa5 Fix: Tooltip contains bogus text after recent button string cleanup
35028d9480 Fix: Memory leaks after recent button string cleanup
fd4dc38264 Fix #107805: Render border without an active region crashes
Compare 98 commits »
Sean Kim commented on issue blender/blender#102377 2024-01-15 23:13:39 +01:00
Auto-Masking: Propagation Steps needed as a global setting

Planning on picking up this work at some point soon since this seems to have stalled out in the last year.

Sean Kim commented on pull request blender/blender#117080 2024-01-13 00:15:36 +01:00
Sculpt: Add per-brush input samples

Tagging @Sergey @HooglyBoogly and @JulienKaspar as specific in the original issue for review.