@DanielBystedt - Thanks for the performance testing!
@TheRedWaxPolice - Thanks for the feedback and testing, I'll look into both of those this coming week.
Looks good to me.
@deadpin - If you want I can make a PR for the equivalent change in main
I get the concern - but this particular code path would be handling the opposite use-case if lassoing a small portion of a large mesh - most pbvh nodes would pass the `BKE_pbvh_node_frustum_exclude…
Animation
data-block
blender/blender#93285 had a similar issue - I think the correct move here is to apply the change to use <
over <=
and then clean up any other usage of this…
No exception is thrown, if to change comparator to:
return a->name.compare(b->name);
I suspect that some values in a list with condition `BLI_strcasecmp_natural(a->name.c_str…
This discussion on the libc++ forum seems possibly related: https://discourse.llvm.org/t/rfc-strict-weak-ordering-checks-in-the-debug-libc/70217
I think I've nailed down the issue to being something in the std::sort
function - I tried swapping out blender's Vector
class for std::vector
in that particular code block and still run into…
d53d7dea71