Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#119140 2024-03-09 23:11:32 +01:00
Sculpt: Add Lasso Hide tool

@DanielBystedt - Thanks for the performance testing!

@TheRedWaxPolice - Thanks for the feedback and testing, I'll look into both of those this coming week.

Sean Kim commented on pull request blender/blender#119233 2024-03-09 02:39:16 +01:00
Fix: Memory leak from sculpt paint lasso

Looks good to me.

@deadpin - If you want I can make a PR for the equivalent change in main

Sean Kim commented on pull request blender/blender#119140 2024-03-08 18:13:25 +01:00
Sculpt: Add Lasso Hide tool

I get the concern - but this particular code path would be handling the opposite use-case if lassoing a small portion of a large mesh - most pbvh nodes would pass the `BKE_pbvh_node_frustum_exclude…

Sean Kim created branch geom-node-mac-fix in Sean-Kim/blender 2024-03-08 00:16:44 +01:00
Sean Kim pushed to geom-node-mac-fix at Sean-Kim/blender 2024-03-08 00:16:44 +01:00
341130be96 Fix: Avoid potential mac std::sort comparator issue
e0c6db81ea Tests: Blacklist microfacet hair test on GPU, due to different curve shape
4d958ca19a Fix: View in Graph Editor not working when object is unselected
Compare 3 commits »
Sean Kim created pull request blender/blender#119189 2024-03-07 23:36:08 +01:00
Fix #119014: Crash on keymap editing for Mac
Sean Kim pushed to 119104-mac-crash at Sean-Kim/blender 2024-03-07 23:29:39 +01:00
2e38e7d1df Fix #119014: Crash on keymap editing for Mac
Sean Kim created branch 119104-mac-crash in Sean-Kim/blender 2024-03-07 23:28:45 +01:00
Sean Kim pushed to 119104-mac-crash at Sean-Kim/blender 2024-03-07 23:28:45 +01:00
e08a3bf9f6 Fix: TBD
4e196f916c Cleanup: Remove unnecessary AssetListStorage class
ab3b8df693 Fix #116249: Compositor: Gizmos ignore backdrop transformations
d99fffc460 GPv3: Legacy Conversion: Animation: Optimize fcurves handling.
90ef46baa1 Anim: DNA for Animation data-block
Compare 10 commits »
Sean Kim commented on issue blender/blender#119014 2024-03-07 19:19:46 +01:00
Crash while editing keymap entry (MacOS only)

blender/blender#93285 had a similar issue - I think the correct move here is to apply the change to use < over <= and then clean up any other usage of this…

Sean Kim commented on issue blender/blender#119014 2024-03-07 19:04:25 +01:00
Crash while editing keymap entry (MacOS only)

No exception is thrown, if to change comparator to:

return a->name.compare(b->name);

I suspect that some values in a list with condition `BLI_strcasecmp_natural(a->name.c_str…

Sean Kim commented on issue blender/blender#119014 2024-03-07 18:09:47 +01:00
Crash while editing keymap entry (MacOS only)

This discussion on the libc++ forum seems possibly related: https://discourse.llvm.org/t/rfc-strict-weak-ordering-checks-in-the-debug-libc/70217

Sean Kim commented on issue blender/blender#119014 2024-03-07 04:33:10 +01:00
Crash while editing keymap entry (MacOS only)

I think I've nailed down the issue to being something in the std::sort function - I tried swapping out blender's Vector class for std::vector in that particular code block and still run into…

Sean Kim pushed to 80390-lasso-gesture-hide at Sean-Kim/blender 2024-03-07 01:23:31 +01:00
a190229af8 Remove extra keymap entry
Sean Kim created pull request blender/blender#119140 2024-03-07 01:02:37 +01:00
Sculpt: Add Lasso Hide tool
Sean Kim pushed to 80390-lasso-gesture-hide at Sean-Kim/blender 2024-03-07 00:59:41 +01:00
0eb000d418 Sculpt: Add Lasso Hide tool
Sean Kim created branch 80390-lasso-gesture-hide in Sean-Kim/blender 2024-03-07 00:49:13 +01:00
Sean Kim pushed to 80390-lasso-gesture-hide at Sean-Kim/blender 2024-03-07 00:49:13 +01:00
82de171391 Sculpt: Add Lasso Hide tool
00b4fdce2c UI: Improvements to Confirmation of Load Factory
3bacd93ba6 UI: Improvements to Confirmation of Load Factory Preferences
06bc23f08e Fix: warnings caused by d53d7dea71
eb8557f8a7 Cleanup: Use snake case for function names in file list
Compare 10 commits »
Sean Kim deleted branch 4.1-sculpt-changes from Sean-Kim/blender-developer-docs 2024-03-07 00:22:31 +01:00
Sean Kim deleted branch gesture-enum-cleanup from Sean-Kim/blender 2024-03-06 06:44:50 +01:00