Sean Kim Sean-Kim
2 Followers · 0 Following
  • Joined on 2023-12-14
Overview Repositories
5
 Projects Public Activity Starred Repositories
1
Sean Kim approved blender/blender#129684 2024-11-01 16:43:16 +01:00
Cleanup: Remame PBVH headers to "paint BVH"
Sean Kim commented on pull request blender/blender#129602 2024-11-01 16:29:20 +01:00
RNA: Assert when failing to find a specified property by name

I am not sure if this is something that people are running from scripts?

Yeah, this was the area I don't know much about and could see as being problematic here. IMO it might make sense to…

Sean Kim commented on issue blender/blender#129662 2024-11-01 08:34:44 +01:00
Corrupt mesh with Subdivision Surface level 6 + GPU Subdivision

Some more data here, on my MBP with a M3 Pro, I cannot get this distorted geometry to appear. I wonder if this is NVIDIA specific?

Operating system: macOS-14.4-arm64-arm-64bit 64 Bits Graphics…

Sean Kim commented on issue blender/blender#129662 2024-11-01 02:36:04 +01:00
Corrupt mesh with Subdivision Surface level 6 + GPU Subdivision

Ran with --log "*,^wm.msgbus.*" --log-level -1 but didn't get anything interesting in particular from the output

Sean Kim approved blender/blender#128278 2024-11-01 01:04:39 +01:00
Subdiv: Remove evaluator C-API wrapper

So, I mainly did manual testing here on a few different meshes:

Sean Kim commented on issue blender/blender#129662 2024-11-01 00:30:10 +01:00
Corrupt mesh with Subdivision Surface level 6 + GPU Subdivision

Possibly related to #94881

Sean Kim opened issue blender/blender#129662 2024-11-01 00:27:54 +01:00
Corrupt mesh with Subdivision Surface level 6 + GPU Subdivision
Sean Kim commented on pull request blender/blender#129609 2024-10-31 22:53:15 +01:00
Refactor: Remove PBVHFrustumPlanes

@blender-bot build

Sean Kim pushed to remove-pbvh-frustum-planes at Sean-Kim/blender 2024-10-31 22:40:27 +01:00
1067f075d0 Working
Sean Kim pushed to remove-pbvh-frustum-planes at Sean-Kim/blender 2024-10-31 21:48:48 +01:00
c3e7be8504 WIP: Refactor: Remove PBVHFrustumPlanes
dd7064b2e1 Cleanup: Various non-functional changes for paint_stroke.cc
3ff2733279 Cleanup: Sculpt: Remove PBVH frustum plane and related calculation
77a7671f54 Cleanup: Avoid writing sculpt session runtime pointer to files
00319f70d0 Merge branch 'blender-v4.3-release'
Compare 82 commits »
Sean Kim deleted branch cleanup-paint-stroke-cc from Sean-Kim/blender 2024-10-31 21:12:21 +01:00
Sean Kim pushed to main at blender/blender 2024-10-31 21:12:18 +01:00
dd7064b2e1 Cleanup: Various non-functional changes for paint_stroke.cc
Sean Kim merged pull request blender/blender#129576 2024-10-31 21:12:17 +01:00
Cleanup: Various non-functional changes for paint_stroke.cc
Sean Kim deleted branch remove-frustum-plane-pbvh from Sean-Kim/blender 2024-10-31 21:10:53 +01:00
Sean Kim pushed to main at blender/blender 2024-10-31 21:10:51 +01:00
3ff2733279 Cleanup: Sculpt: Remove PBVH frustum plane and related calculation
Sean Kim merged pull request blender/blender#129649 2024-10-31 21:10:50 +01:00
Cleanup: Sculpt: Remove PBVH frustum plane and related calculation
Sean Kim commented on pull request blender/blender#129654 2024-10-31 20:47:23 +01:00
Fix #129645: Sculpt color attribute popover never active

@blender-bot build

Sean Kim commented on pull request blender/blender#129654 2024-10-31 20:44:59 +01:00
Fix #129645: Sculpt color attribute popover never active

I'm not sure what the best practice here is, but I couldn't see a way to access this data inside the C++ code for this property, as the RNA runtime for this passes in nullptr for the ED_image_paint_brush_type_use_canvas bContext parameter, and there doesn't appear to be a way to keep this a property and also pass that parameter in, nor does it seem possible to access the currently active brush type from just a bToolRef

Sean Kim created pull request blender/blender#129654 2024-10-31 20:41:42 +01:00
Fix #129645: Color attribute element does not display as active
Sean Kim created branch fix-color-ui-129645 in Sean-Kim/blender 2024-10-31 20:41:12 +01:00