.finish
after applying mask
Overall I think it works as expected. Only thing I noticed is that the operator crashes Blender if the 'Settings' are changed to 'Brush'.
Ack, thanks for catching this. Should have done more…
Just mentioning one other way of specifying an inverse matrix that I've seen (mainly in sculpt / paint code) is imat
. I don't have particularly strong thoughts on how we name things here, but I…
After moving the comment here, I think mentioning that this returns a sorted list by id is potentially relevant to users?
Do you think we should add the SCULPT_vertex_random_access_ensure
method here? I'm still on the fence personally about how we handle those calls & if there's a good way to put them somewhere higher up in the operator such that we can effectively expect the table to always be in a valid state.
Docstring above this line should be removed and put in the header
Nit: Feels a bit odd to me to have this inside sculpt_expand.cc
- maybe put it in sculpt.cc
for now?
Still need to do a bit of cleanup on the code side, but I think functionality wise this can be tested now.