Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim created branch fix-127671-multiplane-scrape in Sean-Kim/blender 2024-09-18 22:55:28 +02:00
Sean Kim pushed to fix-127671-multiplane-scrape at Sean-Kim/blender 2024-09-18 22:55:28 +02:00
497e9496ea Fix #127671: Multiplane scrape causes parts of mesh to disappear
Sean Kim created pull request blender/blender#127815 2024-09-18 22:40:16 +02:00
Fix: Mask from Cavity did not call .finish after applying mask
Sean Kim pushed to fix-finish-mask at Sean-Kim/blender 2024-09-18 22:39:40 +02:00
12686d60b3 Fix: Mask from Cavity did not call .finish after applying mask
Sean Kim created branch fix-finish-mask in Sean-Kim/blender 2024-09-18 22:39:40 +02:00
Sean Kim commented on pull request blender/blender#127787 2024-09-18 21:10:28 +02:00
Sculpt: Add Mask from Boundary Operator

Overall I think it works as expected. Only thing I noticed is that the operator crashes Blender if the 'Settings' are changed to 'Brush'.

Ack, thanks for catching this. Should have done more…

Sean Kim commented on issue blender/blender#127806 2024-09-18 21:01:04 +02:00
Rename camera matrix terminology

Just mentioning one other way of specifying an inverse matrix that I've seen (mainly in sculpt / paint code) is imat. I don't have particularly strong thoughts on how we name things here, but I…

Sean Kim commented on pull request blender/blender#127804 2024-09-18 20:54:35 +02:00
Refactor: Sculpt: Deduplicate symmetry vertex search

After moving the comment here, I think mentioning that this returns a sorted list by id is potentially relevant to users?

Sean Kim commented on pull request blender/blender#127804 2024-09-18 20:54:34 +02:00
Refactor: Sculpt: Deduplicate symmetry vertex search

Do you think we should add the SCULPT_vertex_random_access_ensure method here? I'm still on the fence personally about how we handle those calls & if there's a good way to put them somewhere higher up in the operator such that we can effectively expect the table to always be in a valid state.

Sean Kim commented on pull request blender/blender#127804 2024-09-18 20:54:33 +02:00
Refactor: Sculpt: Deduplicate symmetry vertex search

Docstring above this line should be removed and put in the header

Sean Kim commented on pull request blender/blender#127804 2024-09-18 20:54:32 +02:00
Refactor: Sculpt: Deduplicate symmetry vertex search

Nit: Feels a bit odd to me to have this inside sculpt_expand.cc - maybe put it in sculpt.cc for now?

Sean Kim commented on pull request blender/blender#127787 2024-09-18 07:35:20 +02:00
Sculpt: Add Mask from Boundary Operator

@blender-bot package

Sean Kim commented on pull request blender/blender#127787 2024-09-18 07:35:07 +02:00
Sculpt: Add Mask from Boundary Operator

Still need to do a bit of cleanup on the code side, but I think functionality wise this can be tested now.

Sean Kim created pull request blender/blender#127787 2024-09-18 07:33:21 +02:00
Sculpt: Add Mask from Boundary Operator
Sean Kim created branch create-boundary-mask in Sean-Kim/blender 2024-09-18 07:20:32 +02:00
Sean Kim pushed to create-boundary-mask at Sean-Kim/blender 2024-09-18 07:20:32 +02:00
014f91b852 Sculpt: Add Mask from Boundary Operator
b5d418a83f Refactor: Sculpt: Specialize pose face set IK chain creation
51e9a36c2f Cycles: oneAPI: build binaries for Lunar Lake GPUs
9db50bed04 Fix: Geometry Nodes: use better hash for InstanceReference
2ba69519a8 Fix #127678: Auto-Save Preferences does not work for few anim properties
Compare 10 commits »
Sean Kim deleted branch pose-face-set-init-refactor from Sean-Kim/blender 2024-09-18 05:33:39 +02:00
Sean Kim pushed to main at blender/blender 2024-09-18 05:33:35 +02:00
b5d418a83f Refactor: Sculpt: Specialize pose face set IK chain creation
Sean Kim merged pull request blender/blender#127781 2024-09-18 05:33:35 +02:00
Refactor: Sculpt: Specialize pose face set IK chain creation