On a debug build of the given commit, I get an ASAN crash when using Box Hide - I suspect this issue will be fixed in the latest daily though.
Yeah, apologies, this was more me categorizing my own thoughts. What I meant by "odd" is that given the context of the one-time initialization that the rest of this block I would expect that br…
We discussed in chat previously that one of the benefits for storing this at the SculptSesssion level is that for the paint brush, this data is only computed once, instead of on a per-stroke basis that this PR would change it to - are there any noticeable performance impacts on a large mesh with this change applied for the paint brush?
The naming for this and the next few methods is inconsistent - I think vert_ref for PBVHVertRef, vert_idx or vert_i for index, and vert for int / SubdivCCGCoord / BMVert * makes the most sense to me.
It's true that if there was never a valid last vertex, that the expand operator does something seemingly random. Maybe in that corner case it can pick the closest vertex to the cursor screen…