Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#126161 2024-08-10 01:06:16 +02:00
Refactor: Restructure sculpt shape key updates

From my testing, no, I wasn't able to encounter a situation where this was needed. Since we restore from the unode positions, I don't think we would need to selectively filter that above on line…

Sean Kim opened issue blender/blender#126162 2024-08-10 00:51:49 +02:00
Shape Key allows setting itself in the "Relative To" field
Sean Kim commented on issue blender/blender#126143 2024-08-10 00:36:47 +02:00
Sculpting asset mesh consistently causes segmentation fault

I can verify this on 4.2, but not on 4.2.1 - I suspect this is one of the recent crashes that was fixed.

@Michael_Macha - could you verify on your end that the 4.2.1 RC build [here](https://buil

Sean Kim created pull request blender/blender#126161 2024-08-10 00:19:17 +02:00
cleanup-write-translations
Sean Kim created branch cleanup-write-translations in Sean-Kim/blender 2024-08-10 00:18:04 +02:00
Sean Kim pushed to cleanup-write-translations at Sean-Kim/blender 2024-08-10 00:18:04 +02:00
a17c18003a Refactor: Restructure sculpt shape key updates
810fee35f3 Fix #126074: Sculping on a non-basis shape key modifies mesh
ae13fb5a53 Refactor: Sculpt: Various cleanups in relax brush
3e5751c726 Fix: Animation Editors Dopesheet RNA paths incomplete/wrong
Compare 10 commits »
Sean Kim pushed to main at blender/blender 2024-08-09 22:34:55 +02:00
810fee35f3 Fix #126074: Sculping on a non-basis shape key modifies mesh
Sean Kim closed issue blender/blender#126074 2024-08-09 22:34:53 +02:00
Regression: Sculpting a shapekey results in new shapekeys not being based on the basis shapekey
Sean Kim deleted branch fix-126074 from Sean-Kim/blender 2024-08-09 22:34:52 +02:00
Sean Kim merged pull request blender/blender#126107 2024-08-09 22:34:50 +02:00
Fix #126074: Sculping on a non-basis shape key modifies mesh
Sean Kim pushed to fix-126074 at Sean-Kim/blender 2024-08-09 22:32:21 +02:00
ca871fc6b1 Add const, remove unnecessary comment
Sean Kim commented on pull request blender/blender#126145 2024-08-09 20:45:25 +02:00
Refactor: Sculpt: Various cleanups in relax brush

Ah, thats an interesting consideration, I hadn't thought of that. In that case, I think we would want to apply it to the multires version of the average_positions method too right?

Sean Kim commented on pull request blender/blender#126107 2024-08-09 20:40:12 +02:00
Fix #126074: Sculping on a non-basis shape key modifies mesh

I'll follow up on this afterwards; there's another place that apply_translations_to_shape_keys is used in the undo code, so I don't want to clutter this fix with that cleanup.

Sean Kim commented on pull request blender/blender#126107 2024-08-09 20:39:28 +02:00
Fix #126074: Sculping on a non-basis shape key modifies mesh

Yeah, that's fair. I was trying to think of more descriptive / "why" things to put here since this did cause a bug, but I agree that as is this is just duplicated info.

Sean Kim approved blender/blender#126145 2024-08-09 20:36:27 +02:00
Refactor: Sculpt: Various cleanups in relax brush

One minor comment, otherwise looks good, thanks for the cleanup!

Sean Kim commented on pull request blender/blender#126145 2024-08-09 20:36:25 +02:00
Refactor: Sculpt: Various cleanups in relax brush

Wouldn't it be better to do the multiplication once here at the very end?

Sean Kim created pull request blender/blender#126112 2024-08-09 01:30:32 +02:00
Refactor: Sculpt: Speciailize access of active vert coord for orig_grab_location
Sean Kim commented on pull request blender/blender#126111 2024-08-09 01:28:58 +02:00
Cleanup: Use enum class and constexpr in sculpt_automask.cc

Ah, I didn't realize that that thread had some discussion about constexpr as well as enum class. Thanks for the link. The logic makes sense, though I do still think it's worth clarifying in…