@HooglyBoogly Yeah ignore them. We are looking into those tests.
What is the performance and quality difference? Especially in a more realistic setup where compositor is not only doing denoising, but handles other effects?
Ah, I see. This is because find_package(HIP) is only affecting the current directory and subdirectories.
The more reliable approach would be to add find_package(HIP 5.5.0) in `extern/hipew/C…
Generally it seems fine. There are some cosmetic/readability suggestion which would be nice to incorporate into any new platform-specific code.
Also added Julian as a reviewer for extra pairs…
There is no need to do ED_area_find_under_cursor if we know it will fail on the platform for which we implement a fallback solution.
Include BLI_build_config.h and use #if OS_LINIX.
so that is probably why it links to it.
Can it just assume dynamic linking and use our OpenMP? To ensure ABI compatibility can use headers from our precompiled libraries: https://projects.blen…
Considering we've decided it is not a stopper for 4.3, think it is fine to wait. Maybe even lower the severity level, as it is not something that happens with the official releases?
Bastien…
@ThomasDinges For the 4.3 the decision is simple: we need to avoid regressions. This means:
- if a library after update for 4.3 is linked agains system-wide library but wasn't for 4.2, it needs…
I see, thanks for the insights.
For the X11 I've came up with the following solution:
GHOST_IWindow *GHOST_SystemX11::getWindowUnderCursor(const int32_t /*x*/, const int32_t /*y*/)
{
…It should be possible to use volume_util.h from node_scatter_volume.osl and avoid duplication?
I don't fully understand why metadata on the source file would break colors in the proxy.
Enable automatic device selection in OpenImageDenoise when GPU compositiong is enabled
Ah, so this is not something caused by this PR? What Richard said sounded like an issue introduced by this PR. That said...
On more tests, I might be wrong. I can no longer reproduce the…
@howardt I don't think we should be adding code that checks for potential conflicts. Bevel is one potential user of OpenMP. There are other usages in Blender (Mataflow, Bullet, Libmv, quadriflow).…
@aras_p Sorry, wall-o-text coming...
I've attached a test scene which, I believe, demonstrates the issue Richard run into. It might another issue, but an issue nevertheless :)
Steps to…
There are plenty of warnings, but the build succeeds. And the warnings is exactly what we want from the Clang-Tidy running first time on a platform :)