Someone from the people who are able to deploy need to be tagged (either as CC or reviweer).
The target branch I am not sure about. From what I can see the repository follows our typical…
When a PR changes the way things renders, and require an update of regression tests it always worth mentioning it in the description and commit message. Especially when something is as straightforw…
That would incur a performance cost for the sequencer though
Good point.
Add a comment around the IMB_anim_absolute that it does not guarantee float buffer is linear?
And then also…
@Alaska I wouldn't mind some help here (the NVidia machine I have access to is a shared one, and currently used for some other bug investigation by the team).
- Does the issue still happen with…
On the code side it seems fine, and doesn't seem to conflict of what we'd need to do for #130153? I guess we can make a test package?
P.S. The Gitea has a bit of confusing state now, showing…
Yeah, just do find_package(HIP 5.5.0) to the hipew. I think this is what you've done in the recent update. Now we can remove this set(HIP_VERSION_MAJOR ${HIP_VERSION_MAJOR} CACHE INTERNAL "").
The general rule is: byte buffers have un-premultiplied alpha, float buffers have pre-multiplied alpha.
@iss There needs to be much fuller explanation in this PR's description.
@deadpin Please check with Campbell/Bastien, they are quite active in the in the Python API module.
The logic seems fine. There are a couple of thoughts tho:
So definitely something else than just a lack of interop is involved here.
--pre flag to pipenv installs for doc-api
It would make it much easier to review the changes if they are explained a bit better: the fact that --pre is added can be seen from the code. What can't be seen in the why is it needed, what…
@Jeroen-Bakker The original TODO had much clearer scope. Here it is unclear the root cause of slowdown:
- It is unclear whether rendering happens on CPU or GPU.
- Having 200x slowdown on display…