The abbreviation CSD is a bit cryptic, I think. In the context of this PR I understand it, but when I would come across WM_window_set_use_csd(win, true) in the wild, I wouldn't know what it meant.
Silly nitpick, but the style guide tells us to end comments with a full stop.
Second nitpick: better full variable names like backgroundColor than tbBackgroundCol. The 'title bar' part is implied by the function.
@Brainzman Like you said on the chat, for macOS, letting AppKit do the job of restoring window position sounds like a good line of inquiry. It could be a matter of:
- Adding some GHOST [function…
Thanks for testing, Jonas! It would be great if you could look into this – when it fits into your GSoC project, that is, of course.
I did some Stackoverflow digging and now I understand the…
When multi frame editing isn't enabled, the frame_falloff is set to 1.0 (so no falloff).
I've improved the comments intransform_mode_curveshrinkfatten.cc a bit, because there it's more…
That's right 👍
And the array is filled with a back pointer to Drawing because that information isn't available in PointerRNA ptr (because Drawing isn't an ID type).
@ChengduLittleA That one is put on hold for now. It needs a design task first, agreement on the design and then (adjusting) the implementation – not enough time in 4.3 to get all those steps…
The & makes the difference here: this function is returning a pointer indicating the nth element in the StrokeSlice array. In rna_StrokeSlice_index_get this pointer is used to calculate the…
So, if I understand it correctly, the proposal is what's already implemented in [#121407: WIP: GPv3: RNA for frame, drawing, stroke and point](blender/blender#121…
