Sietse Brouwer SietseB
0 Followers · 0 Following
  • Joined on 2023-02-08
Repositories
1
 Projects Public Activity Starred Repositories
Sietse Brouwer commented on pull request blender/blender#120508 2024-04-11 19:16:49 +02:00
GPv3: Implementation of sculpt mode tools

You can use ed::greasepencil::retrieve_editable_drawings_with_falloff() here. That one calculates the multi_frame_falloff factor for the drawings.

Sietse Brouwer commented on pull request blender/blender#113953 2024-04-11 16:12:46 +02:00
GPv3: Cutter tool

We are sure (because the segments intersect), but I changed it anyway. You never know, in a leap year with full moon... 😉

Sietse Brouwer pushed to gpv3-cutter-tool at SietseB/blender 2024-04-11 16:11:07 +02:00
5643bcdae7 Code review changes
Sietse Brouwer pushed to gpv3-cutter-tool at SietseB/blender 2024-04-11 12:47:46 +02:00
04fb6c5b2c Use EnumerableThreadSpecific instead of mutex
8e1130dbf7 Cleanup: format space_toolsystem_toolbar.py
Compare 2 commits »
Sietse Brouwer commented on pull request blender/blender#113953 2024-04-11 01:17:58 +02:00
GPv3: Cutter tool

I skipped the use of BLI_lasso_is_edge_inside for now, because it adds some complexity. Line segments touched by the lasso can be intersected by other curves. Handling cases like: ![Intersecte…

Sietse Brouwer pushed to gpv3-cutter-tool at SietseB/blender 2024-04-11 00:36:25 +02:00
164336f8ea Parallelization moved to lassoed strokes, calculation of intersections done up-front
66409a0a69 Code review changes
Compare 2 commits »
Sietse Brouwer approved blender/blender#120454 2024-04-10 10:04:13 +02:00
GPv3: Resize curve when no points are selected to copy.

And another good catch! 👍

Sietse Brouwer pushed to gpv3-weight-paint-overlay at SietseB/blender 2024-04-09 10:38:40 +02:00
06123bbadf Cleanup: make format on .glsl
Sietse Brouwer commented on issue blender/blender#120291 2024-04-09 00:00:11 +02:00
GPv3: Make new strokes selected after operators (copy/paste etc.)

@PratikPB2123 Making the pasted strokes selected, is probably easiest to set the .selection state of the strokes/points on the clipboard, before joining the geometries. Then you don't have to…

Sietse Brouwer approved blender/blender#120363 2024-04-08 23:18:58 +02:00
GPv3: Deselect everything from all visible drawings when pasting strokes

Thanks for the fix!

Sietse Brouwer commented on issue blender/blender#120291 2024-04-05 21:37:31 +02:00
GPv3: Make new strokes selected after operators (copy/paste etc.)

@PratikPB2123 You are completely right. That's the mistake I made in the copy/paste code: I assumed there was always a .selection attribute already on the strokes at the clipboard (since you…

Sietse Brouwer pushed to gpv3-cutter-tool at SietseB/blender 2024-04-02 23:56:45 +02:00
0ef898f049 Improved comments and improved readability of point ranges (with 'start' and 'end' fields)
717a4b3e0d Merge branch 'main' into gpv3-cutter-tool
5de40790d0 Compositor: Set W to 1 in Float to Vector conversion
77a34791a3 Fix #119938: performance regression when adding output attribute
03bcd7390a Formatting
Compare 600 commits »
Sietse Brouwer pushed to gpv3-weight-paint-tools at SietseB/blender 2024-04-02 19:18:52 +02:00
304a8f0cf9 Merge branch 'main' into gpv3-weight-paint-tools
5de40790d0 Compositor: Set W to 1 in Float to Vector conversion
77a34791a3 Fix #119938: performance regression when adding output attribute
03bcd7390a Formatting
45a0b6cc1a Cleanup: GPv3: Use const in a few places
Compare 599 commits »
Sietse Brouwer pushed to gpv3-weight-paint-overlay at SietseB/blender 2024-04-02 18:52:14 +02:00
61248b8ac2 Cleanup after merge with main
dc9b60fefa Merge branch 'main' into gpv3-weight-paint-overlay
5de40790d0 Compositor: Set W to 1 in Float to Vector conversion
77a34791a3 Fix #119938: performance regression when adding output attribute
03bcd7390a Formatting
Compare 484 commits »
Sietse Brouwer deleted branch gpv3-fix-vgroup-ordering from SietseB/blender 2024-03-28 14:54:31 +01:00
Sietse Brouwer commented on pull request blender/blender#119979 2024-03-28 14:54:21 +01:00
Fix: GPv3: Hitting an assert when changing vertex group order

@PratikPB2123 Thanks! (And that's right, I don't have commit rights.)

Sietse Brouwer created pull request blender/blender#119979 2024-03-27 19:49:08 +01:00
Fix: GPv3: Hitting an assert when changing vertex group order
Sietse Brouwer pushed to gpv3-fix-vgroup-ordering at SietseB/blender 2024-03-27 19:37:59 +01:00
590698f353 Fix: GPv3: Hitting an assert when changing vertex group order
0709c07d04 Cleanup: Use actual class instead of base class
4d9678c483 Fix: Sun Beams node is off by half a pixel
e9dc9ef9a2 Fix #119936: Crash selecting in mask editor
5ae5614d1e Fix: Chroma Key differs from reference implementation
Compare 10 commits »
Sietse Brouwer created branch gpv3-fix-vgroup-ordering in SietseB/blender 2024-03-27 19:37:58 +01:00
Sietse Brouwer deleted branch gpv3-fix-layer-blend-mode from SietseB/blender 2024-03-27 09:56:52 +01:00