Nikita Sirgienko Sirgienko
1 Followers · 0 Following
  • Joined on 2020-12-10
Repositories
1
 Projects Public Activity Starred Repositories
Nikita Sirgienko pushed to main at blender/blender 2024-02-07 09:43:34 +01:00
06dc5363a9 Cycles: Denoise on CPU by default for offline render
Nikita Sirgienko commented on issue blender/blender#117931 2024-02-07 04:11:05 +01:00
OIDN does not swap devices when editing "Use GPU" while a viewport render is active.

@Alaska, thanks for reporting! I will definitely take a look - I remember seen some code allowing Denoising parameters in GUI and Denoiser Parameters for Denoiser be in desynchronize under some…

Nikita Sirgienko pushed to main at blender/blender 2024-02-06 23:41:03 +01:00
057b80dc9e Cycles: Log devices that are supported by OIDN
b2678156fa Cycles: Unify logging for devices discovery
Compare 2 commits »
Nikita Sirgienko commented on pull request blender/blender#115265 2024-02-06 21:35:06 +01:00
Cycles: Added quality parameter for OIDN

I was testing the patch when denoising 4K image, and I did not see any time difference between Balanced and High quality. On my M2 Ultra the time was about 6 seconds in both configurations for…

Nikita Sirgienko pushed to main at blender/blender 2024-02-06 20:58:57 +01:00
280b5c89ae Cycles: Set quality parameter for OIDN
Nikita Sirgienko pushed to main at blender/blender 2024-02-06 20:28:09 +01:00
c174fd4e06 Cycles: Fix Python error in has_oidn_gpu_devices
Nikita Sirgienko deleted branch ui_setting_rthw_checkbox_unification from Sirgienko/blender 2024-02-06 20:06:25 +01:00
Nikita Sirgienko merged pull request blender/blender#117904 2024-02-06 20:06:23 +01:00
Cycles: Gray out hardware raytracing checkboxes when not available
Nikita Sirgienko pushed to main at blender/blender 2024-02-06 20:06:22 +01:00
0100547515 Cycles: Gray out hardware raytracing checkboxes when not available
Nikita Sirgienko commented on pull request blender/blender#117904 2024-02-06 19:38:11 +01:00
Cycles: Gray out hardware raytracing checkboxes when not available

I could, but I have decided to leave this change to the Apple people - maybe they have some strong opinion why this option should disappear on MacOS instead of being gray out.

Nikita Sirgienko closed pull request blender/blender#117876 2024-02-06 17:50:29 +01:00
Cycles: Allow to choose OIDN denoise device on per-scene basis.
Nikita Sirgienko commented on pull request blender/blender#117876 2024-02-06 17:50:26 +01:00
Cycles: Allow to choose OIDN denoise device on per-scene basis.

As blender/blender#117874 have been merged - ability to tune OIDN device on per-scene level was provided and there is no need for this PR anymore.

4c26b25c13 Adress requested changes
Nikita Sirgienko commented on pull request blender/blender#117904 2024-02-06 15:30:27 +01:00
Cycles: Gray out hardware raytracing checkboxes when not available

UI Example - RT HW checkbox is available, when device or one of the devices is supporting this type of functionality: image UI Example - But…

Nikita Sirgienko commented on pull request blender/blender#117904 2024-02-06 15:27:52 +01:00
Cycles: Gray out hardware raytracing checkboxes when not available
  • @Stefan_Werner @xavierh for avereness. @brecht , this is quite simple change, but I have wanted to give you a chance to review this, as it is changing UI behavior a bit.
Nikita Sirgienko created pull request blender/blender#117904 2024-02-06 15:26:36 +01:00
Cycles: Gray out hardware raytracing checkboxes when not available
23e610d837 Cycles: Gray out hardware raytracing checkboxes when not available
0baee63b85 Cleanup: correct comment
30f2db21d7 EEVEE-Next: Implement viewlayer filters
0e706c9699 UI: Move Bone Collection specials menu up
ec4b074506 Build: Update 4.1 libraries to fix CVEs
Compare 10 commits »
Nikita Sirgienko created branch ui_setting_rthw_checkbox_unification in Sirgienko/blender 2024-02-06 15:25:50 +01:00
Nikita Sirgienko commented on pull request blender/blender#117874 2024-02-06 15:23:57 +01:00
Cycles: Allow to disable OIDN on GPU on per-scene basis.

@brecht , What about scenario with Render on CPU and OIDN running on GPU? Currently, UI/UX do not support this, in opposite to the Optix Denoiser, where it is supported (regardless to the Cycles…

Nikita Sirgienko commented on pull request blender/blender#117876 2024-02-06 02:04:25 +01:00
Cycles: Allow to choose OIDN denoise device on per-scene basis.

UI Example - Drop list will look like (there is no Optix entry here, because I do not have NVIDIA card on this machine): image

UI Example…