blender
/
blender
132
398
Fork 577
Code Issues 6.2k Pull Requests 744 Projects 19 Wiki Activity

Cycles: Added quality parameter for OIDN #115265

Merged
Stefan Werner merged 2 commits from Stefan_Werner/blender:oidn_quality into main 2023-11-23 12:35:38 +01:00
Conversation 4 Commits 2 Files Changed 11 +89 -9
Stefan Werner commented 2023-11-22 12:28:33 +01:00
Member
Copy Link

OpenImageDenoise has two modes, high quality and balanced. This now exposes the modes as user parameters, with viewport denoising defaulting to balanced and final frame rendering set to high quality.

Ref #115045

OpenImageDenoise has two modes, high quality and balanced. This now exposes the modes as user parameters, with viewport denoising defaulting to balanced and final frame rendering set to high quality. Ref #115045
Stefan Werner added 1 commit 2023-11-22 12:28:46 +01:00
buildbot/vexp-code-patch-coordinator Build done. Details
ee82841432 Cycles: Added quality parameter for OIDN 
OpenImageDenoise has two modes, high quality and balanced.
This now exposes the modes as user parameters, with viewport
denoising defaulting to balanced and final frame rendering
set to high quality.
Stefan Werner added the
Interest
Cycles
 label 2023-11-22 12:29:19 +01:00
Stefan Werner added this to the 4.1 milestone 2023-11-22 12:29:33 +01:00
Stefan Werner added this to the Render & Cycles project 2023-11-22 12:29:36 +01:00
Brecht Van Lommel requested review from Brecht Van Lommel 2023-11-22 18:47:56 +01:00
Brecht Van Lommel requested review from Sergey Sharybin 2023-11-22 18:47:56 +01:00
Brecht Van Lommel commented 2023-11-22 18:50:06 +01:00
Owner
Copy Link

@blender-bot build

@blender-bot build
Brecht Van Lommel approved these changes 2023-11-22 18:51:19 +01:00
Brecht Van Lommel commented 2023-11-22 18:51:58 +01:00
Owner
Copy Link

Accepting assuming tests pass.

Accepting assuming tests pass.
Stefan Werner added 1 commit 2023-11-23 12:34:22 +01:00
Stefan Werner merged commit 2e2291dd83 into main 2023-11-23 12:35:38 +01:00
Stefan Werner deleted branch oidn_quality 2023-11-23 12:35:39 +01:00
Sergey Sharybin requested changes 2023-11-23 12:59:16 +01:00
Sergey Sharybin left a comment
Owner
Copy Link

There is something quite odd going on.

It would be very nice to have some performance numbers. Adding options without setting artists expectations is not something we should do. It might've also have answered the confusion I had while testing the patch.

I was testing the patch when denoising 4K image, and I did not see any time difference between Balanced and High quality. On my M2 Ultra the time was about 6 seconds in both configurations for F12 render. Also didn't see performance different in the viewport.

So either something is not working as its expected, or some better communication is needed w.r.t when the option is actually bringing time saving. Until this is clarified I don't think we should be landing new options which artists will have the same confusion as I did.

There is something quite odd going on. It would be very nice to have some performance numbers. Adding options without setting artists expectations is not something we should do. It might've also have answered the confusion I had while testing the patch. I was testing the patch when denoising 4K image, and I did not see any time difference between Balanced and High quality. On my M2 Ultra the time was about 6 seconds in both configurations for F12 render. Also didn't see performance different in the viewport. So either something is not working as its expected, or some better communication is needed w.r.t when the option is actually bringing time saving. Until this is clarified I don't think we should be landing new options which artists will have the same confusion as I did.
Stefan Werner commented 2023-11-23 13:55:11 +01:00
Author
Member
Copy Link

May apologies for maybe merging this too early. I reverted it, sorry for the noise in the git logs now. After double-checking, this parameter is not active on all backends and should probably be held back until we figure out how handle denoiser device selection.

May apologies for maybe merging this too early. I reverted it, sorry for the noise in the git logs now. After double-checking, this parameter is not active on all backends and should probably be held back until we figure out how handle denoiser device selection.
Nikita Sirgienko commented 2024-02-06 21:35:05 +01:00
Member
Copy Link

I was testing the patch when denoising 4K image, and I did not see any time difference between Balanced and High quality. On my M2 Ultra the time was about 6 seconds in both configurations for F12 render. Also didn't see performance different in the viewport.
So either something is not working as its expected, or some better communication is needed w.r.t when the option is actually bringing time saving. Until this is clarified I don't think we should be landing new options which artists will have the same confusion as I did.

For documentation purposes and as a recap of recent events: the topic of these changes was discussed in today's Cycles meeting with Brecht, and there was a consensus that it makes sense to apply these values to OIDN based on the type of the render (preview or offline). However, as Sergey previously noted, there is no point to reflect this level of control in the UI at this time, as it does not result in any significant or noticeable changes to the Blender's User Experience.

I have taken the previously reviewed changes, removed the GUI-related code that introduced the new UI element, and recommitted the changes with the original default values (Balanced quality mode for preview and High quality mode for offline rendering) set as constants. For the time being, this approach results in differences only for NVIDIA, as it is the only platform where these two distinct quality profiles yield any significant performance changes, albeit with very minor alterations in image quality.

I have attached a diff report: you can check a difference between Stefan original changes and my modifications - it is visible here that only GPU related code have been changes and the rest of the differences between diffs is just non-changed lines (shown by git) being different after 3 months of Blender development.

> I was testing the patch when denoising 4K image, and I did not see any time difference between Balanced and High quality. On my M2 Ultra the time was about 6 seconds in both configurations for F12 render. Also didn't see performance different in the viewport. > So either something is not working as its expected, or some better communication is needed w.r.t when the option is actually bringing time saving. Until this is clarified I don't think we should be landing new options which artists will have the same confusion as I did. For documentation purposes and as a recap of recent events: the topic of these changes was discussed in today's Cycles meeting with Brecht, and there was a consensus that it makes sense to apply these values to OIDN based on the type of the render (preview or offline). However, as Sergey previously noted, there is no point to reflect this level of control in the UI at this time, as it does not result in any significant or noticeable changes to the Blender's User Experience. I have taken the previously reviewed changes, removed the GUI-related code that introduced the new UI element, and recommitted the changes with the original default values (Balanced quality mode for preview and High quality mode for offline rendering) set as constants. For the time being, this approach results in differences only for NVIDIA, as it is the only platform where these two distinct quality profiles yield any significant performance changes, albeit with very minor alterations in image quality. I have attached a diff report: you can check a difference between Stefan original changes and my modifications - it is visible here that only GPU related code have been changes and the rest of the differences between diffs is just non-changed lines (shown by git) being different after 3 months of Blender development.
115265_Stefan_code_versus_Nikita_Reitroduction.html
129 KiB
Sign in to join this conversation.
Reviewers
No reviewers
Brecht Van Lommel
Sergey Sharybin
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
4.1
Projects
Clear projects
No project
Render & Cycles
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115265
No description provided.
Delete Branch "Stefan_Werner/blender:oidn_quality"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?