Cycles: Gray out hardware raytracing checkboxes when not available #117904

Nikita Sirgienko · 2024-02-06T15:26:24+01:00

Nikita Sirgienko commented

2024-02-06 15:26:24 +01:00

HWRT checkboxes visibility in the Cycles settings wasn't uniform across devices.
With this change, we unify it and gray out these in case HWRT isn't available.

HWRT checkboxes visibility in the Cycles settings wasn't uniform across devices. With this change, we unify it and gray out these in case HWRT isn't available.

Nikita Sirgienko added 1 commit 2024-02-06 15:26:35 +01:00

23e610d837 Cycles: Gray out hardware raytracing checkboxes when not available

HWRT checkboxes visibility in the Cycles settings wasn't uniform across devices.
With this change, we unify it and gray out these in case HWRT isn't available.

Nikita Sirgienko requested review from Brecht Van Lommel 2024-02-06 15:26:45 +01:00

Nikita Sirgienko added the

Module

Render & Cycles

label 2024-02-06 15:26:52 +01:00

Nikita Sirgienko added this to the 4.1 milestone 2024-02-06 15:26:57 +01:00

Nikita Sirgienko added this to the Render & Cycles project 2024-02-06 15:27:02 +01:00

Nikita Sirgienko commented

2024-02-06 15:27:51 +01:00

@Stefan_Werner @xavierh for avereness.
@brecht , this is quite simple change, but I have wanted to give you a chance to review this, as it is changing UI behavior a bit.

+ @Stefan_Werner @xavierh for avereness. @brecht , this is quite simple change, but I have wanted to give you a chance to review this, as it is changing UI behavior a bit.

Nikita Sirgienko commented

2024-02-06 15:30:27 +01:00

UI Example - RT HW checkbox is available, when device or one of the devices is supporting this type of functionality:

UI Example - But gray out, if none of selected device(s) are supporting this functionality:

UI Example - RT HW checkbox is available, when device or one of the devices is supporting this type of functionality: ![image](/attachments/af8f1bd9-68cb-45a8-aee6-7c4b10477c27) UI Example - But gray out, if none of selected device(s) are supporting this functionality: ![image](/attachments/ca2fdc15-f3b9-4679-b2f1-08230ff5e564)

image.png

99 KiB

image.png

105 KiB

👍 1

Brecht Van Lommel reviewed 2024-02-06 16:57:54 +01:00

intern/cycles/blender/addon/properties.py Outdated

						
				@ -1723,3 +1724,2 @@

				                has_cuda, has_optix, has_hip, has_metal, has_oneapi, has_hiprt = _cycles.get_device_types()

				                row = layout.row()

				                row.enabled = has_hiprt

				                row.enabled = has_rt_api_support['HIP']

Brecht Van Lommel commented

2024-02-06 16:57:04 +01:00

Use row.active. No reason to disallow toggling the option entirely, just graying out is enough.

Use `row.active`. No reason to disallow toggling the option entirely, just graying out is enough.

Sirgienko marked this conversation as resolved

intern/cycles/blender/addon/properties.py Outdated

						
				@ -1727,3 +1727,4 @@

				        elif compute_device_type == 'ONEAPI' and _cycles.with_embree_gpu:

				            row = layout.row()

				            row.enabled = has_rt_api_support['ONEAPI']

Brecht Van Lommel commented

2024-02-06 16:57:49 +01:00

Same comment.

Sirgienko marked this conversation as resolved

Nikita Sirgienko added 1 commit 2024-02-06 17:36:27 +01:00

4c26b25c13 Adress requested changes

Brecht Van Lommel approved these changes 2024-02-06 19:35:57 +01:00

Brecht Van Lommel reviewed 2024-02-06 19:36:41 +01:00

intern/cycles/blender/addon/properties.py

						
				@ -1715,3 +1716,3 @@

				                if is_arm64:

				                    col.prop(self, "kernel_optimization_level")

				                if has_rt_api_support:

				                if has_rt_api_support['METAL']:

Brecht Van Lommel commented

2024-02-06 19:36:41 +01:00

We could gray out here too for consistency, as you mentioned.

Nikita Sirgienko commented

2024-02-06 19:38:11 +01:00

I could, but I have decided to leave this change to the Apple people - maybe they have some strong opinion why this option should disappear on MacOS instead of being gray out.

Brecht Van Lommel commented

2024-02-06 19:51:08 +01:00

Ok, does not need to be done as part of this PR.

👍 1