Tarek-Yasser
0 Followers · 0 Following
  • Joined on 2023-02-09
Repositories
1
 Projects Public Activity Starred Repositories
Tarek-Yasser commented on issue blender/blender#105557 2023-03-12 09:29:28 +01:00
Sculpt: issues with new menu operators

Should I open a new issue for this? In my opinion, even if they are not feasible to fix right now, it should be listed as a known issue on this board at least.

Definitely agree. it's better to…

Tarek-Yasser pushed to 102427_continued at Tarek-Yasser/blender 2023-03-08 18:49:23 +01:00
418e2e0fc6 Merge branch '102427_continued' of projects.blender.org:Tarek-Yasser/blender into 102427_continued
d7c31e948e Merge branch 'main' of https://projects.blender.org/blender/blender into 102427_continued
60f35207d4 Fix: Hide ".uv_seam" attribute in UI
27b9ce6ab6 Mesh: Avoid writing unnecessary attributes
1354e3108b const_cast no longer needed for ntreeIsRegistered.
Compare 145 commits »
Tarek-Yasser commented on issue blender/blender#105557 2023-03-08 17:12:24 +01:00
Sculpt: issues with new menu operators

I think I already encountered and reported the box/lasso trim/add misbehavior in in a comment on #104718.

IIRC,…

Tarek-Yasser commented on pull request blender/blender#104718 2023-03-08 17:06:16 +01:00
Sculpt: Add Transform, Trim, and Mesh Filter operators to Sculpt menu

Hi Lasso trim and lasso add are the same, both are trimming, are the same operator and mode. I didn't know if I should put it here or sould I open an issue.

Hello, I think I already…

Tarek-Yasser pushed to sculpt_mode_add_menu_operators at Tarek-Yasser/blender 2023-03-03 17:56:40 +01:00
b530a1c6f3 Merge branch 'main' of https://projects.blender.org/blender/blender into sculpt_mode_add_menu_operators
915ff8d152 Cleanup: Use references for mesh poly variables
45cff837bc Cleanup: Use simpler iterator for mesh polygons
e1a0c09f06 Merge branch 'blender-v3.5-release'
e7ba8247de Merge branch 'blender-v3.5-releas' into main
Compare 191 commits »
Tarek-Yasser pushed to 102427_continued at Tarek-Yasser/blender 2023-03-03 17:52:43 +01:00
cab6349e3d Merge branch 'main' into 102427_continued
915ff8d152 Cleanup: Use references for mesh poly variables
45cff837bc Cleanup: Use simpler iterator for mesh polygons
e1a0c09f06 Merge branch 'blender-v3.5-release'
e7ba8247de Merge branch 'blender-v3.5-releas' into main
Compare 120 commits »
Tarek-Yasser created pull request blender/blender#105410 2023-03-03 17:49:49 +01:00
Sculpt: Add operators to Mask, Face Sets, and Paint menus.
Tarek-Yasser commented on issue blender/blender#102427 2023-03-03 17:38:47 +01:00
Sculpt Mode: Add exisiting Tools as Menu Operators

@JulienKaspar @JosephEagar Ok, I think I'm really done now.

The last push should (hopefully) finalize Color Filter.

Stuff implemented:

  • The mouse cursor now switches to `WM_CUROSOR_EW_SCR…
Tarek-Yasser pushed to sculpt_mode_add_menu_operators at Tarek-Yasser/blender 2023-03-03 17:20:57 +01:00
c72cd77ebe Cleanup: Replace some `NULL`s with `nullptr`.
Tarek-Yasser pushed to 102427_continued at Tarek-Yasser/blender 2023-03-03 17:17:08 +01:00
86fe5f3282 Filter Color: Update status bar with controls in modal mode.
b61a74b0f6 Filter Color: Add modal keymap and handle cancelling.
696ac86aba UI: Set cursor to `WM_CURSOR_EW_SCROLL` for color filter operations.
b358b2cec8 UI: Fix misnamed "Filter Color" to "Fill Color".
cbd2db470b Merge branch 'main' of https://projects.blender.org/blender/blender into 102427_continued
Compare 77 commits »
Tarek-Yasser commented on pull request blender/blender#104718 2023-02-28 20:23:00 +01:00
Sculpt: Add Transform, Trim, and Mesh Filter operators to Sculpt menu

@JosephEagar The notes you mentioned should (hopefully) be addressed now.

For the memory leak, I did try freeing nodes, but the unfreed blocks message still showed up.

I inspected the…

Tarek-Yasser pushed to sculpt_mode_add_menu_operators at Tarek-Yasser/blender 2023-02-28 20:17:14 +01:00
a685beabb8 Fix: Undo not working properly with Mesh Filter
Tarek-Yasser pushed to sculpt_mode_add_menu_operators at Tarek-Yasser/blender 2023-02-28 19:35:51 +01:00
76a7387276 Cleanup: Fix memory leaking when cancelling Filter Mesh operators.
Tarek-Yasser commented on issue blender/blender#102427 2023-02-28 18:00:23 +01:00
Sculpt Mode: Add exisiting Tools as Menu Operators

Ok, let's say we were to implement this. There are a few things that I think should be considered:

  • Which other operators would need to be changed?
  • How would they access the scene color?…
Tarek-Yasser commented on issue blender/blender#102427 2023-02-28 11:56:30 +01:00
Sculpt Mode: Add exisiting Tools as Menu Operators

So I spent yesterday playing with the code you posted and looking at the python examples and API documentation.

The code you posted needed some small modifications to work:

class…
Tarek-Yasser commented on issue blender/blender#102427 2023-02-27 00:34:16 +01:00
Sculpt Mode: Add exisiting Tools as Menu Operators

Another update:

  • Finished up the Face Sets menu. Also did a few basic tests to make sure things work. Note that the sculpt_face_set_edit operator seems to need the redo panel treatment.

-…

Tarek-Yasser pushed to 102427_continued at Tarek-Yasser/blender 2023-02-26 23:48:07 +01:00
f916846044 UI: Add a few operators to the `Face Sets` menu.
2efa17679e Merge branch 'main' of https://projects.blender.org/blender/blender into 102427_continued
8b543bfa3a Merge branch 'blender-v3.5-release'
bf27a239c7 Fix: segfault when setting value in empty bit span
9335150f8c Cleanup: move some function implementations out of header
Compare 258 commits »
Tarek-Yasser created branch 102427_continued in Tarek-Yasser/blender 2023-02-26 23:19:44 +01:00
Tarek-Yasser pushed to 102427_continued at Tarek-Yasser/blender 2023-02-26 23:19:44 +01:00
4bef597a72 UI: Update `Mask` menu according to issue 102427.
Tarek-Yasser commented on pull request blender/blender#104718 2023-02-26 22:49:51 +01:00
Sculpt: Add Transform, Trim, and Mesh Filter operators to Sculpt menu

Ok, I think I'm done with this PR, It's getting a teeny tiny too big.

I've spent the last couple of days investigating the memory leak and the greying out of Erase Displacement to no avail so I…