Amélie Fondevilla amelief
0 Followers · 0 Following
  • https://www.afonde.com/

  • Research Engineer at the animation studio Les Fées Spéciales. Occasional contributor to Grease Pencil.

  • Joined on 2022-01-17
Repositories
1
 Projects Public Activity Starred Repositories
Amélie Fondevilla merged pull request blender/blender#110890 2023-08-08 11:26:29 +02:00
GPv3: New is_layer_active function
Amélie Fondevilla pushed to main at blender/blender 2023-08-08 11:26:29 +02:00
6e66125f34 GPv3: New is_layer_active function
Amélie Fondevilla pushed to gpv3-move-keyframe at amelief/blender 2023-08-08 11:15:55 +02:00
f95e6ebfcc Changes due to rebase
5d3a63842e Refactor
cef0fb325e Add grease pencil API function move frame at
f1b6b3d397 Refactor
575d60690d Reset the frames before applying changes to the map
Compare 28 commits »
Amélie Fondevilla approved blender/blender#110890 2023-08-08 09:16:09 +02:00
GPv3: New is_layer_active function
Amélie Fondevilla commented on pull request blender/blender#110890 2023-08-08 09:10:46 +02:00
GPv3: New is_layer_active function

Maybe here we could check if the layer is nullptr, and return false in that case.

Amélie Fondevilla pushed to gpv3-move-keyframe at amelief/blender 2023-08-07 18:20:34 +02:00
42ca4bb57b Changes due to rebase
ae3852029a Refactor
cd4cb46d01 Add grease pencil API function move frame at
2555736b83 Refactor
45deb35259 Reset the frames before applying changes to the map
Compare 183 commits »
Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-07 15:37:46 +02:00
822a302812 Use the brush's falloff curve in the soft eraser
ada9bd7aee Add the falloff curve UI in the eraser tool
2f41dd63f3 Update the paint settings function with the new grease pencil paint mode.
93f556e767 Add brush strength controller in the UI
eca604ed31 Fix: wrong map passed to gather attributes
Compare 36 commits »
Amélie Fondevilla deleted branch gpv3-eraser-fix-floating-point-issue from amelief/blender 2023-08-07 15:11:42 +02:00
Amélie Fondevilla pushed to main at blender/blender 2023-08-07 15:11:42 +02:00
242e94acec GPv3: Fix floating-point error in the hard eraser tool.
Amélie Fondevilla merged pull request blender/blender#110801 2023-08-07 15:11:41 +02:00
GPv3: Fix floating-point error in the hard eraser tool.
9e0ffaf6b1 More integers with explicit size
3100e2a6f1 More integers with explicit size
Amélie Fondevilla commented on pull request blender/blender#110890 2023-08-07 14:47:16 +02:00
GPv3: New is_layer_active function

Hey, the patch looks good to me. I think it would be even better if this PR included a new grease_pencil->is_layer_active function that we could use everywhere. I was planning to do this after…

c68ba65c3b Refactor contains point
c424eb581c Explicit casts
62af3caac8 Explicit integer types
Compare 3 commits »
Amélie Fondevilla approved blender/blender#110791 2023-08-07 14:04:40 +02:00
GPv3: Include other channel selection modes
Amélie Fondevilla commented on pull request blender/blender#110791 2023-08-07 13:30:24 +02:00
GPv3: Include other channel selection modes

Oh, yes, sorry I forgot about that. Well, forget about the first part of my comment then. We can still use grease_pencil->set_active_layer though.

Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-07 12:52:44 +02:00
6d78ae7632 Use the brush's falloff curve in the soft eraser
28a15ae5e4 Add the falloff curve UI in the eraser tool
236e77ede4 Update the paint settings function with the new grease pencil paint mode.
3e87003fc3 Add brush strength controller in the UI
77b2dbb820 Fix: wrong map passed to gather attributes
Compare 142 commits »
Amélie Fondevilla suggested changes for blender/blender#110791 2023-08-07 12:26:11 +02:00
GPv3: Include other channel selection modes

Thanks for the patch. I think it would be nice if we use the API a little more to manipulate the layers' data, I've left a few comments in that direction. (Actually, this could have been in my review of the previous PR, sorry.)

Amélie Fondevilla commented on pull request blender/blender#110791 2023-08-07 12:26:10 +02:00
GPv3: Include other channel selection modes

if ((layer->is_selected()) && (selectmode != SELECT_EXTEND_RANGE))

Amélie Fondevilla commented on pull request blender/blender#110791 2023-08-07 12:26:10 +02:00
GPv3: Include other channel selection modes

Better to use grease_pencil->get_active_layer() == ale->data;