GPv3: New is_layer_active function #110890

Pratik Borhade · 2023-08-07T13:54:59+02:00

Pratik Borhade commented

2023-08-07 13:54:59 +02:00

New GreasePencil function to determine whether the layer
is active.

New GreasePencil function to determine whether the layer is active.

Pratik Borhade added 1 commit 2023-08-07 13:55:10 +02:00

e4c218ad87 Cleanup: Use GPv3 layer api

Missed in 56832ed59a

Pratik Borhade requested review from Amélie Fondevilla 2023-08-07 13:55:28 +02:00

Amélie Fondevilla commented

2023-08-07 14:47:16 +02:00

Hey, the patch looks good to me. I think it would be even better if this PR included a new grease_pencil->is_layer_active function that we could use everywhere. I was planning to do this after the layer selection pr is merged, but if you want to do that would be great.

Hey, the patch looks good to me. I think it would be even better if this PR included a new `grease_pencil->is_layer_active` function that we could use everywhere. I was planning to do this after the layer selection pr is merged, but if you want to do that would be great.

Pratik Borhade commented

2023-08-08 04:48:05 +02:00

Sure, I'll do that

Pratik Borhade added 1 commit 2023-08-08 08:41:11 +02:00

edb186d09d New is_layer_active function

Pratik Borhade changed title from ~~Cleanup: Use GPv3 layer api~~ to Cleanup: New is_layer_active function

2023-08-08 08:41:39 +02:00

Amélie Fondevilla reviewed 2023-08-08 09:10:45 +02:00

source/blender/blenkernel/intern/grease_pencil.cc

						
				@ -1729,2 +1729,4 @@

				}

				const bool GreasePencil::is_layer_active(const blender::bke::greasepencil::Layer *layer) const

				{

Amélie Fondevilla commented

2023-08-08 09:10:45 +02:00

Maybe here we could check if the layer is nullptr, and return false in that case.

Maybe here we could check if the layer is `nullptr`, and return false in that case.

👍 1

filedescriptor marked this conversation as resolved

Pratik Borhade added 1 commit 2023-08-08 09:15:14 +02:00

c52aa5a6e0 Add null check

Amélie Fondevilla approved these changes 2023-08-08 09:16:08 +02:00

Amélie Fondevilla requested review from Falk David 2023-08-08 09:16:48 +02:00

Falk David added this to the Grease Pencil project 2023-08-08 10:18:46 +02:00

Falk David requested changes 2023-08-08 10:22:10 +02:00

Falk David left a comment

One comment about the return type (make sure to also update the header). Otherwise this looks good!

source/blender/blenkernel/intern/grease_pencil.cc Outdated

						
				@ -1728,6 +1728,14 @@ void GreasePencil::set_active_layer(const blender::bke::greasepencil::Layer *lay

				      reinterpret_cast<const GreasePencilLayer *>(layer));

				}

				const bool GreasePencil::is_layer_active(const blender::bke::greasepencil::Layer *layer) const