Amélie Fondevilla amelief
  • https://www.afonde.com/
  • Research Engineer at the animation studio Les Fées Spéciales. Occasional contributor to Grease Pencil.

  • Joined on 2022-01-17
Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-08-01 09:31:57 +02:00
898eaec510 Refactor
Amélie Fondevilla commented on pull request blender/blender#110649 2023-07-31 12:43:18 +02:00
GPv3: Insert grease pencil keyframe from the dopesheet

Note: There is a TODO left in insert_duplicate_frame, because we need to add a user to the drawing if the function is called with the do_instance option. We need #110579 to do so.

However,…

Amélie Fondevilla created pull request blender/blender#110649 2023-07-31 12:38:46 +02:00
GPv3: Insert grease pencil keyframe from the dopesheet
Amélie Fondevilla pushed to gpv3-insert-keyframe at amelief/blender 2023-07-31 12:32:22 +02:00
126c9164e9 Add additive drawing mode in UI
e91f8b00d0 Cleanup : preparing for the user count to be increased.
5d8c025a64 Fix wrong function name
c9fb8e8cbd Implement insert keyframe
45d69765a0 Add API functions to duplicate a drawing
Compare 10 commits »
Amélie Fondevilla created branch gpv3-insert-keyframe in amelief/blender 2023-07-31 12:32:21 +02:00
Amélie Fondevilla pushed to main at blender/blender 2023-07-31 12:23:41 +02:00
6f8ff2846f GPv3: Add API function to get active frame
Amélie Fondevilla deleted branch gpv3-frame-at-function from amelief/blender 2023-07-31 12:23:40 +02:00
Amélie Fondevilla merged pull request blender/blender#110583 2023-07-31 12:23:39 +02:00
GPv3: Add API function to get active frame
Amélie Fondevilla pushed to gpv3-frame-at-function at amelief/blender 2023-07-31 12:06:01 +02:00
42e16dde83 Refactor
Amélie Fondevilla pushed to gpv3-frame-at-function at amelief/blender 2023-07-31 11:54:54 +02:00
c99640c924 Add non const version of the function
d476649e80 Format comment
2324dfed17 Comment
b6cc44a15e Renamed variable
276321624d Refactor drawing index at function
Compare 62 commits »
Amélie Fondevilla pushed to main at blender/blender 2023-07-31 10:35:47 +02:00
b40e8242ca GPv3 : Select circle/lasso grease pencil frames
Amélie Fondevilla closed issue blender/blender#110521 2023-07-31 10:35:46 +02:00
GPv3 : Select circle/lasso grease pencil frames
Amélie Fondevilla merged pull request blender/blender#110558 2023-07-31 10:35:44 +02:00
GPv3 : Select circle/lasso grease pencil frames
Amélie Fondevilla commented on pull request blender/blender#110558 2023-07-31 10:28:48 +02:00
GPv3 : Select circle/lasso grease pencil frames

Looks good to me !

Amélie Fondevilla commented on pull request blender/blender#110558 2023-07-28 18:38:59 +02:00
GPv3 : Select circle/lasso grease pencil frames

Another remark : comments should start with a capital letter and end with a point. (e.g. /* check the necessary regions */ > /* Check the necessary regions. */)

Amélie Fondevilla commented on pull request blender/blender#110558 2023-07-28 18:34:11 +02:00
GPv3 : Select circle/lasso grease pencil frames

You can also type :

Amélie Fondevilla commented on pull request blender/blender#110558 2023-07-28 18:34:11 +02:00
GPv3 : Select circle/lasso grease pencil frames

It is preferable to use explicit cast here : pt[0] = float(item.key);

Amélie Fondevilla suggested changes for blender/blender#110558 2023-07-28 18:34:11 +02:00
GPv3 : Select circle/lasso grease pencil frames

Thank you for the PR, it's looking good.

Amélie Fondevilla pushed to gpv3-frame-at-function at amelief/blender 2023-07-28 16:51:59 +02:00
bb7361ef33 Add non const version of the function
15326fd815 Format comment
Compare 2 commits »