Amélie Fondevilla amelief
0 Followers · 0 Following
  • https://www.afonde.com/

  • Research Engineer at the animation studio Les Fées Spéciales. Occasional contributor to Grease Pencil.

  • Joined on 2022-01-17
Repositories
1
 Projects Public Activity Starred Repositories
Amélie Fondevilla suggested changes for blender/blender#111426 2023-08-24 14:39:27 +02:00
GPv3: Delete channels

Looks good, I just have a few comments.

Amélie Fondevilla commented on pull request blender/blender#111426 2023-08-24 14:39:26 +02:00
GPv3: Delete channels

There is a missing tag here, so that the viewport gets updated :

Amélie Fondevilla commented on pull request blender/blender#111426 2023-08-24 14:39:26 +02:00
GPv3: Delete channels

Good catch. I think I would be best if this was in its own PR.

Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-23 14:36:25 +02:00
02340eb723 Replace int64 by int for points and curves indices
8ddbbcc8ac Add comment
4b0c663ebe Small typo
Compare 3 commits »
Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-23 14:30:06 +02:00
94e6621f42 Removed unused variable
457c0516fa Remove debug print
b6a0227c6f Fix issues with cyclic curves
bde19d0eda Unify intersection functions for soft and hard eraser
9d1f9582d3 Edit comment
Compare 78 commits »
Amélie Fondevilla deleted branch gpv3-erase-operator-refactor from amelief/blender 2023-08-23 14:13:59 +02:00
Amélie Fondevilla merged pull request blender/blender#111390 2023-08-23 14:13:57 +02:00
GPv3: Refactor code for the hard eraser
Amélie Fondevilla pushed to main at blender/blender 2023-08-23 14:13:56 +02:00
1193f2d7ec GPv3: Refactor code for the hard eraser
Amélie Fondevilla pushed to gpv3-erase-operator-refactor at amelief/blender 2023-08-23 14:11:01 +02:00
55313fc3b4 Update comments
Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-23 13:02:47 +02:00
97e9f5a739 Remove debug print
Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-23 13:02:06 +02:00
21569a7aa1 Fix issues with cyclic curves
c4f4360a97 Unify intersection functions for soft and hard eraser
8fa0b1a873 Edit comment
6222c9af45 Refactor
Compare 4 commits »
Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-23 12:36:10 +02:00
d85aeefe82 Fix error in intersection indices
667661af88 Refactor: use contiguous array instead of vectors
8de0871d76 Update initial factor for intersection to keep the sorting valid.
Compare 3 commits »
Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-23 12:35:39 +02:00
d0ad35a692 Fix missing update of the ring index in the case of one-point strokes
9cae89abf5 Keep caps option in UI also for soft eraser
d3268aaee4 Cleanup: renaming functions
05746483cf Fix: remove 1px sample in curve falloff
a88491f478 Cleanup falloff and rings
Compare 53 commits »
Amélie Fondevilla commented on pull request blender/blender#111390 2023-08-23 10:50:40 +02:00
GPv3: Refactor code for the hard eraser

Agree. It was so much easier to use Array<Vector> to figure out how to deal with intersections, because for the hard eraser there's a max of 2 intersections per segment, but for the soft eraser,…

Amélie Fondevilla pushed to gpv3-erase-operator-refactor at amelief/blender 2023-08-23 10:50:37 +02:00
1d1f030ef0 Refactor: use contiguous array instead of vectors
Amélie Fondevilla pushed to gpv3-erase-operator-refactor at amelief/blender 2023-08-23 09:59:10 +02:00
f96b49992d Cleanup: Rename variable
ac8b06f502 Cleanup: replace int64 by int for point and curve indices
3ce0680db2 Cleanup: output parameters with r_ prefix
1a556a73ec Cleanup: enum class instead of enum
d40685e1ce Cleanup: initialization with equal sign
Compare 5 commits »
Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-22 17:54:00 +02:00
fc56c01c2c Fix missing update of the ring index in the case of one-point strokes
Amélie Fondevilla pushed to gpv3-erase-operator-refactor at amelief/blender 2023-08-22 17:25:42 +02:00
9dd9bc918d Comments
0b10220121 Refactor code for the hard eraser
6cfda322a6 Fix: GPv3: Stroke Eraser does not work with one-point strokes.
acd6dd96b7 Camera: Move panoramic projection settings to DNA
23fc8126be Color management: Shrink Filmic LUT size down without noticeable difference
Compare 5 commits »
Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-22 17:06:34 +02:00
3291bcdb74 Keep caps option in UI also for soft eraser
Amélie Fondevilla pushed to gpv3-erase-operator-soft-mode at amelief/blender 2023-08-22 17:06:17 +02:00
bd31070d53 Cleanup: renaming functions
7985b6f791 Fix: remove 1px sample in curve falloff
eb1fbbd9fa Cleanup falloff and rings
ea6e9e5a15 Move up intersections functions
64acdc1184 Cleanup: use Span instead of Array ref
Compare 47 commits »