GPv3: Delete channels #111426

Pratik Borhade · 2023-08-23T13:06:02+02:00

Pratik Borhade commented

2023-08-23 13:06:02 +02:00

Support deleting Grease pencil channels in dopesheet.
remove_layer function is used to remove the layer from GP object.

Support deleting Grease pencil channels in dopesheet. `remove_layer` function is used to remove the layer from GP object.

Pratik Borhade added 1 commit 2023-08-23 13:06:14 +02:00

d72798d60b GPv3: Delete channels

Support deleting Grease pencil channels in dopesheet.
Also fix a minor condition in filters code which restricts from editing the
channel data.

Pratik Borhade requested review from Falk David 2023-08-23 13:06:35 +02:00

Pratik Borhade requested review from Amélie Fondevilla 2023-08-23 13:06:35 +02:00

Pratik Borhade added the

Module

Grease Pencil

label 2023-08-23 13:06:44 +02:00

Pratik Borhade added this to the Grease Pencil project 2023-08-24 08:23:39 +02:00

Amélie Fondevilla requested changes 2023-08-24 14:39:25 +02:00

Amélie Fondevilla left a comment

Looks good, I just have a few comments.
I think it would be best if we did two separate PR for the filtering fix and the delete operator.
And one tag is missing in the delete code.

Also, I get a double free memory issue when I try to undo, but I think this is an unrelated issue, because it does the same when deleting frames.

Looks good, I just have a few comments. I think it would be best if we did two separate PR for the filtering fix and the delete operator. And one tag is missing in the delete code. Also, I get a double free memory issue when I try to undo, but I think this is an unrelated issue, because it does the same when deleting frames.

source/blender/editors/animation/anim_channels_edit.cc

						
				@ -2195,0 +2196,4 @@

				        using namespace blender::bke::greasepencil;

				        GreasePencil *grease_pencil = reinterpret_cast<GreasePencil *>(ale->id);

				        Layer *layer = static_cast<Layer *>(ale->data);

				        grease_pencil->remove_layer(*layer);

Amélie Fondevilla commented

2023-08-24 14:36:16 +02:00

There is a missing tag here, so that the viewport gets updated :
DEG_id_tag_update(&grease_pencil->id, ID_RECALC_GEOMETRY);

There is a missing tag here, so that the viewport gets updated : ` DEG_id_tag_update(&grease_pencil->id, ID_RECALC_GEOMETRY);`

👍 1

PratikPB2123 marked this conversation as resolved

source/blender/editors/animation/anim_filter.cc

						
				@ -1777,3 +1777,3 @@

				  /* Only if the layer is editable. */

				  if ((filter_mode & ANIMFILTER_FOREDIT) && !layer.is_locked()) {

				  if ((filter_mode & ANIMFILTER_FOREDIT) && layer.is_locked()) {