- Kaunas, Lithuania
- https://aras-p.info/
- Joined on
2022-01-20 -
-
This does happen in "heavy" tests that I did -- tons of video clips, large timeline, and several source files that span the whole timeline that are almost always visible. After wild panning and…
Defensive habits, I guess. Will replace with an assert.
Right, previously this was within space_sequencer indeed. What would you suggest to do? WM jobs are kinda "perfect" for actually doing this -- they run in the background, then can be cancelled…
Ah cool, I'll remove it then! Missing media is not an issue for this PR, it actually gets "null" thumbnails and handles them just fine, without causing endless requests.
To me this feels fine -- this is a function called "once per frame" to maintain cache capacity. "once per frame" is quite important since it ticks the logical timestamps etc. "user of this cache"…
Previous code, whenever the timeline view changed at all (panning/zooming), was canceling any in-flight thumbnail requests and starting from scratch, essentially.
Now I changed it to not flat…
Yes there's quite a bit of logic that is weird/funky but I have not changed it, I just moved it from render.cc. Cleaning all that up and "somehow" improving which parts of strips want to show…
I don't understand it either. I just moved the function from render.cc, since it is no longer needed there. What is the logic of the function keeps on being mystery to me, but I have not changed…
While I was not able to test performance improvement on my Gold edit (see comment about C++ exception above), on another file that I have with several video tracks each cut into many pieces…
With latest commit on this PR, I am getting a C++ exception "resource deadlock would occur" (seemingly the mutex is already locked by the same thread? but not 100% sure). This is on Windows, on Gold (gold-edit-v804 - I forget where I got it from, Francesco or Sergey gave it to me, entering frame 2875).
Ah ok! I was not sure whether BLI utilities or C++ std is preferred. Will change.
Timeline area X axis coordinate is "frames", Y axis is "channels". So this is +-30 frames from what is visible, and +-1 channels. It is similar to the previous cache code, but indeed perhaps would…
Similar to my suggestion at #124549, maybe that behavior should be reverted, and actual logic changed to:
- Draw text with the color as it would be (from theme or elsewhere),
- Draw text outline…
As @Harley says, the glyph advancing right now is not correct. This can be easily seen in cursive/script fonts, e.g. "Dancing Script" (https://fontlibrary.org/en/font/dancing). Current main branch…
Minor: I'd think that using namespace blender is not needed since what follows is already a sub-namesspace of that (blender::seq)