- Kaunas, Lithuania
- https://aras-p.info/
- Joined on
2022-01-20 -
-
@iss FYI sequencer render tests on buildbot are crashing after this change merge.
@ChengduLittleA I could at some point. But overall, the geometry node for file imports is the new GSoC 24 project (just added in #125587), so maybe @Devashish-Lal could look into it first.
Code looks good, I've added some minor comments that should be easy to address.
Currently the icon is still ICON_LINKED from back when this feature was called "Linked strips". Should this be changed, and if so, to which icon
@pablovazquez opinions on what icon to use to…
Would probably be less error prone to introduce a constant for both lines of code, e.g.
Minor: to me probably would read easier if bool changed = false would be moved further below, right before the LISTBASE_FOREACH loop. And the !SEQ_is_strip_connected check would simply return false.
Minor, and probably this is following existing code, but I'm wondering whether the comments for Identifiers, Api callbacks and Flags are much useful here (and in SEQUENCER_OT_disconnect). It is very clear what these function parts are already, without the comments.
What would orig_start be used for? Currently indeed it seems to not be used for anything, so why have it at all?
seq_list argument could be const blender::VectorSet<Sequence *> & I think, no need to copy the whole vector set by value.