Fix #125490: Scene strip incorrectly rendered as solid view. #125947

Richard Antalik · 2024-08-06T08:48:13+02:00

Richard Antalik commented

2024-08-06 08:48:13 +02:00

Prevent VSE cache returning image when running render job.

Previously, before render job was started, cache was cleared, but since
disk cache is not cleared, it returned an image. Now cache is not
cleared, but it does not return or store images when rendering.

Prevent VSE cache returning image when running render job. Previously, before render job was started, cache was cleared, but since disk cache is not cleared, it returned an image. Now cache is not cleared, but it does not return or store images when rendering.

Richard Antalik added 1 commit 2024-08-06 08:48:24 +02:00

Fix #125490 : Scene strip incorrectly rendered as solid view. c0b1023aa2

Prevent VSE cache returning image when running render job.

Previously, before render job was started, cache was cleared, but since
disk cache is not cleared, it returned an image. Now cache is not
cleared, but it does not return or store images when rendering.

Richard Antalik requested review from Sergey Sharybin 2024-08-06 08:50:57 +02:00

Richard Antalik requested review from Sebastian Parborg 2024-08-06 08:50:58 +02:00

Sebastian Parborg approved these changes 2024-08-06 14:51:50 +02:00

Sebastian Parborg left a comment

LGTM

Just a question out of curiosity:
Would caching in a render time context make sense at some point in the future?

IE you pre-cache part of the frames your are going to render and then do encoding in batches?

So you pre-render 10-60 frames and then send that batch to the ffmpeg encoder while we start pre-rendering the next batch of frames.

LGTM Just a question out of curiosity: Would caching in a render time context make sense at some point in the future? IE you pre-cache part of the frames your are going to render and then do encoding in batches? So you pre-render 10-60 frames and then send that batch to the ffmpeg encoder while we start pre-rendering the next batch of frames.

Sergey Sharybin approved these changes 2024-08-07 10:37:21 +02:00

Richard Antalik commented

2024-08-07 15:20:45 +02:00

LGTM

Just a question out of curiosity:
Would caching in a render time context make sense at some point in the future?

IE you pre-cache part of the frames your are going to render and then do encoding in batches?

So you pre-render 10-60 frames and then send that batch to the ffmpeg encoder while we start pre-rendering the next batch of frames.

It would not work correctly in this case, where in VSE preview you use solid shading, but you want rendered shading for final render.

But in general, I am not sure. With scenes, that are fast to render it may help, but not sure how much. With more complex scenes, encoding could be 1% of CPU time with current implamentation. Making it 0.1% would not help you much.

> LGTM > > Just a question out of curiosity: > Would caching in a render time context make sense at some point in the future? > > IE you pre-cache part of the frames your are going to render and then do encoding in batches? > > So you pre-render 10-60 frames and then send that batch to the ffmpeg encoder while we start pre-rendering the next batch of frames. It would not work correctly in this case, where in VSE preview you use solid shading, but you want rendered shading for final render. But in general, I am not sure. With scenes, that are fast to render it may help, but not sure how much. With more complex scenes, encoding could be 1% of CPU time with current implamentation. Making it 0.1% would not help you much.

Richard Antalik merged commit 5ecb70964e into main

2024-08-07 15:23:38 +02:00

Richard Antalik referenced this issue from a commit

2024-08-07 15:24:01 +02:00

Fix #125490: Scene strip incorrectly rendered as solid view.

Richard Antalik deleted branch 125490

2024-08-07 15:24:59 +02:00

Aras Pranckevicius commented

2024-08-07 16:16:03 +02:00

@iss FYI sequencer render tests on buildbot are crashing after this change merge.

Sergey Sharybin referenced this issue from a commit

2024-08-07 17:04:05 +02:00