archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Fix T71374 EEVEE: Fix Node group socket not converting inputs as in Cycles

Browse Source 
Pretty straight Forward. Create a temp node during sockets expansion to
force the conversion to float.
This commit is contained in:
Clément Foucault
2020-01-23 17:40:40 +01:00
parent 39ae4804a8
commit c2e21b2329
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/nodes/shader/node_shader_tree.c
View File

@@ -332,7 +332,16 @@ static void ntree_shader_groups_expand_inputs(bNodeTree *localtree)
bNodeSocket *group_socket = group_node->inputs.first;
for (; group_socket; group_socket = group_socket->next) {
if (group_socket->link != NULL) {
bNodeLink *link = group_socket->link;
/* Fix the case where the socket is actually converting the data. (see T71374)
* We only do the case of lossy conversion to float.*/
if ((group_socket->type == SOCK_FLOAT) && (link->fromsock->type != link->tosock->type)) {
bNode *node = nodeAddStaticNode(NULL, localtree, SH_NODE_RGBTOBW);
nodeAddLink(localtree, link->fromnode, link->fromsock, node, node->inputs.first);
nodeAddLink(localtree, node, node->outputs.first, group_node, group_socket);
}
continue;
}