Correct links to the ghost comment navigation

2023-01-22 15:39:58 +01:00
parent 4d0bbd65c2
commit 63443cef58
2 changed files with 2 additions and 2 deletions
--- a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
+++ b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
@@ -229,7 +229,7 @@ final class PhabricatorInlineCommentAdjustmentEngine
        $diff_id = $changeset->getDiffID();
        $inline_id = $inline->getID();
        $revision_id = $revision->getID();
-        $href = "/D{$revision_id}?id={$diff_id}#inline-{$inline_id}";
+        $href = "D{$revision_id}.id{$diff_id}#inline-{$inline_id}";

        $inline
          ->makeEphemeral(true)
--- a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
+++ b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
@@ -141,7 +141,7 @@ final class PHUIDiffInlineCommentDetailView
        array(
          'class' => 'ghost-icon',
          'href' => $ghost['href'],
-          'target' => '_blank',
+          // 'target' => '_blank',
        ),
        $ghost_icon);
      $classes[] = 'inline-comment-ghost';