archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Correct links to the ghost comment navigation

Browse Source
This commit is contained in:
Sergey Sharybin
2023-01-22 15:39:58 +01:00
parent 4d0bbd65c2
commit 63443cef58
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
View File

@@ -229,7 +229,7 @@ final class PhabricatorInlineCommentAdjustmentEngine
$diff_id = $changeset->getDiffID(); $diff_id = $changeset->getDiffID();
$inline_id = $inline->getID(); $inline_id = $inline->getID();
$revision_id = $revision->getID(); $revision_id = $revision->getID();
$href = "/D{$revision_id}?id={$diff_id}#inline-{$inline_id}"; $href = "D{$revision_id}.id{$diff_id}#inline-{$inline_id}";
$inline $inline
->makeEphemeral(true) ->makeEphemeral(true)

2
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
View File

@@ -141,7 +141,7 @@ final class PHUIDiffInlineCommentDetailView
array( array(
'class' => 'ghost-icon', 'class' => 'ghost-icon',
'href' => $ghost['href'], 'href' => $ghost['href'],
'target' => '_blank', // 'target' => '_blank',
), ),
$ghost_icon); $ghost_icon);
$classes[] = 'inline-comment-ghost'; $classes[] = 'inline-comment-ghost';